From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@suse.de>
Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>,
Ronald Sieber <Ronald.Sieber@systec-electronic.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] drivers/staging/epl: do not use CLONE_SIGHAND with allow_signal()
Date: Mon, 4 May 2009 00:15:31 +0200 [thread overview]
Message-ID: <20090503221531.GA26415@redhat.com> (raw)
Not sure this patch is really needed since kernel_thread() is deprecated
(and checkpatch.pl complains).
But we should not use kernel_thread(CLONE_SIGHAND) if we are going to play
with signals.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
drivers/staging/epl/EplSdoUdpu.c | 3 ++-
drivers/staging/epl/ShbIpc-LinuxKernel.c | 8 ++++----
2 files changed, 6 insertions(+), 5 deletions(-)
--- PTRACE/drivers/staging/epl/EplSdoUdpu.c~AS_2 2009-04-06 00:03:39.000000000 +0200
+++ PTRACE/drivers/staging/epl/EplSdoUdpu.c 2009-05-04 00:03:50.000000000 +0200
@@ -334,7 +334,8 @@ tEplKernel EplSdoUdpuConfig(unsigned lon
}
// create Listen-Thread
SdoUdpInstance_g.m_ThreadHandle =
- kernel_thread(EplSdoUdpThread, &SdoUdpInstance_g, CLONE_KERNEL);
+ kernel_thread(EplSdoUdpThread, &SdoUdpInstance_g,
+ CLONE_FS | CLONE_FILES);
if (SdoUdpInstance_g.m_ThreadHandle == 0) {
Ret = kEplSdoUdpThreadError;
goto Exit;
--- PTRACE/drivers/staging/epl/ShbIpc-LinuxKernel.c~AS_2 2009-04-06 00:03:39.000000000 +0200
+++ PTRACE/drivers/staging/epl/ShbIpc-LinuxKernel.c 2009-05-03 23:54:04.000000000 +0200
@@ -532,8 +532,8 @@ tShbError ShbIpcStartSignalingNewData(tS
//create thread for signalling new data
pShbMemInst->m_tThreadNewDataId =
- kernel_thread(ShbIpcThreadSignalNewData, pShbInstance_p,
- CLONE_KERNEL);
+ kernel_thread(ShbIpcThreadSignalNewData, pShbInstance_p,
+ CLONE_FS | CLONE_FILES);
Exit:
return ShbError;
@@ -636,8 +636,8 @@ tShbError ShbIpcStartSignalingJobReady(t
pShbMemHeader->m_fJobReady = FALSE;
//create thread for signalling new data
pShbMemInst->m_tThreadJobReadyId =
- kernel_thread(ShbIpcThreadSignalJobReady, pShbInstance_p,
- CLONE_KERNEL);
+ kernel_thread(ShbIpcThreadSignalJobReady, pShbInstance_p,
+ CLONE_FS | CLONE_FILES);
Exit:
return ShbError;
}
reply other threads:[~2009-05-03 22:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090503221531.GA26415@redhat.com \
--to=oleg@redhat.com \
--cc=Ronald.Sieber@systec-electronic.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.krueger@systec-electronic.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox