* [PATCH] drivers/staging/epl: do not use CLONE_SIGHAND with allow_signal()
@ 2009-05-03 22:15 Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2009-05-03 22:15 UTC (permalink / raw)
To: Andrew Morton, Greg Kroah-Hartman
Cc: Daniel Krueger, Ronald Sieber, linux-kernel
Not sure this patch is really needed since kernel_thread() is deprecated
(and checkpatch.pl complains).
But we should not use kernel_thread(CLONE_SIGHAND) if we are going to play
with signals.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
drivers/staging/epl/EplSdoUdpu.c | 3 ++-
drivers/staging/epl/ShbIpc-LinuxKernel.c | 8 ++++----
2 files changed, 6 insertions(+), 5 deletions(-)
--- PTRACE/drivers/staging/epl/EplSdoUdpu.c~AS_2 2009-04-06 00:03:39.000000000 +0200
+++ PTRACE/drivers/staging/epl/EplSdoUdpu.c 2009-05-04 00:03:50.000000000 +0200
@@ -334,7 +334,8 @@ tEplKernel EplSdoUdpuConfig(unsigned lon
}
// create Listen-Thread
SdoUdpInstance_g.m_ThreadHandle =
- kernel_thread(EplSdoUdpThread, &SdoUdpInstance_g, CLONE_KERNEL);
+ kernel_thread(EplSdoUdpThread, &SdoUdpInstance_g,
+ CLONE_FS | CLONE_FILES);
if (SdoUdpInstance_g.m_ThreadHandle == 0) {
Ret = kEplSdoUdpThreadError;
goto Exit;
--- PTRACE/drivers/staging/epl/ShbIpc-LinuxKernel.c~AS_2 2009-04-06 00:03:39.000000000 +0200
+++ PTRACE/drivers/staging/epl/ShbIpc-LinuxKernel.c 2009-05-03 23:54:04.000000000 +0200
@@ -532,8 +532,8 @@ tShbError ShbIpcStartSignalingNewData(tS
//create thread for signalling new data
pShbMemInst->m_tThreadNewDataId =
- kernel_thread(ShbIpcThreadSignalNewData, pShbInstance_p,
- CLONE_KERNEL);
+ kernel_thread(ShbIpcThreadSignalNewData, pShbInstance_p,
+ CLONE_FS | CLONE_FILES);
Exit:
return ShbError;
@@ -636,8 +636,8 @@ tShbError ShbIpcStartSignalingJobReady(t
pShbMemHeader->m_fJobReady = FALSE;
//create thread for signalling new data
pShbMemInst->m_tThreadJobReadyId =
- kernel_thread(ShbIpcThreadSignalJobReady, pShbInstance_p,
- CLONE_KERNEL);
+ kernel_thread(ShbIpcThreadSignalJobReady, pShbInstance_p,
+ CLONE_FS | CLONE_FILES);
Exit:
return ShbError;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-05-03 22:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-03 22:15 [PATCH] drivers/staging/epl: do not use CLONE_SIGHAND with allow_signal() Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox