From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753161AbZEDBUb (ORCPT ); Sun, 3 May 2009 21:20:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751336AbZEDBUW (ORCPT ); Sun, 3 May 2009 21:20:22 -0400 Received: from cantor.suse.de ([195.135.220.2]:53553 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbZEDBUW (ORCPT ); Sun, 3 May 2009 21:20:22 -0400 Date: Sun, 3 May 2009 18:15:34 -0700 From: Greg KH To: Samuel Ortiz Cc: Mark Brown , linux-kernel@vger.kernel.org, Greg KH Subject: Re: [PATCH] mfd: remove driver_data direct access of struct device Message-ID: <20090504011534.GA21972@suse.de> References: <20090430221850.GA18541@kroah.com> <20090501112525.GD6975@sirena.org.uk> <20090501151535.GC16106@suse.de> <20090503215940.GD3278@sortiz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090503215940.GD3278@sortiz.org> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 03, 2009 at 11:59:41PM +0200, Samuel Ortiz wrote: > Hi Greg, > > On Fri, May 01, 2009 at 08:15:35AM -0700, Greg KH wrote: > > On Fri, May 01, 2009 at 12:25:25PM +0100, Mark Brown wrote: > > > On Thu, Apr 30, 2009 at 03:18:50PM -0700, Greg Kroah-Hartman wrote: > > > > From: Greg Kroah-Hartman > > > > > > > In the near future, the driver core is going to not allow direct access > > > > to the driver_data pointer in struct device. Instead, the functions > > > > dev_get_drvdata() and dev_set_drvdata() should be used. These functions > > > > have been around since the beginning, so are backwards compatible with > > > > all older kernel versions. > > > > > > > Cc: Samuel Ortiz > > > > Signed-off-by: Greg Kroah-Hartman > > > > > > For wm8400: > > > > > > Acked-by: Mark Brown > > > > Thanks. Do you mind if I take this in my tree? Or is there a mfd tree > > somewhere that it should go through? > I applied this one to my for-next branch. > When do you plan to remove the direct driver_data direct access ? In 2.6.31. > I'm asking to know if I should schedule this patch for sometimes > earlier than the next merge window. next merge window is fine with me. thanks, greg k-h