From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jeff Mahoney <jeffm@suse.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ReiserFS Mailing List <reiserfs-devel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@ftp.linux.org.uk>,
Alexander Beregalov <a.beregalov@gmail.com>,
David <david@unsolicited.net>
Subject: Re: [PATCH] reiserfs: Expand i_mutex to enclose lookup_one_len
Date: Mon, 4 May 2009 07:13:27 +0100 [thread overview]
Message-ID: <20090504061327.GG8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <49FE7448.2040302@suse.com>
On Mon, May 04, 2009 at 12:51:20AM -0400, Jeff Mahoney wrote:
> Huh. I didn't see that still in there. That's an artifact of an earlier
> version of the code where I kept a reference to /.reiserfs_priv/xattrs.
> Then I decided that .reiserfs_priv was all I needed to cache (to avoid
> recursive i_mutex locking on the fs root) and dropped the caching of
> xattrs. Looks like it didn't get totally cleared out.
It's not that simple ;-/ You check it in journalling code, AFAICS in order
to decide how much will that sucker take (due to extra mkdir?) and something
will need to be done with that check.
Anyway, I'm going to push all that stuff to #for-next, so that -next would
pick it. I have *not* touched the xattr_root logics, so if you could do
that on top of your patch + my incremental...
next prev parent reply other threads:[~2009-05-04 6:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 16:11 [PATCH] reiserfs: Expand i_mutex to enclose lookup_one_len Jeff Mahoney
2009-05-01 16:37 ` Alexander Beregalov
2009-05-01 19:56 ` Andrew Morton
2009-05-01 20:36 ` Jeff Mahoney
2009-05-03 8:52 ` Al Viro
2009-05-03 9:15 ` Al Viro
2009-05-03 10:06 ` Al Viro
2009-05-04 4:51 ` Jeff Mahoney
2009-05-04 6:13 ` Al Viro [this message]
2009-05-04 16:40 ` Jeff Mahoney
2009-05-05 19:29 ` Jeff Mahoney
2009-05-04 5:01 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090504061327.GG8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=a.beregalov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@unsolicited.net \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox