Re: introducing __GFP_PANIC

Cyrill Gorcunov
2009-05-04T10:01:23Z

[Pekka Enberg - Mon, May 04, 2009 at 12:57:11PM +0300]
| On Mon, 2009-05-04 at 13:08 +0400, Cyrill Gorcunov wrote:
| > Index: linux-2.6.git/mm/oom_kill.c
| > =====================================================================
| > --- linux-2.6.git.orig/mm/oom_kill.c
| > +++ linux-2.6.git/mm/oom_kill.c
| > @@ -422,6 +422,16 @@ static int oom_kill_process(struct task_
| > return oom_kill_task(p);
| > }
| >
| > +void oom_panic(gfp_t gfp_mask, unsigned int order)
| > +{
| > + if (likely(!(gfp_mask & __GFP_PANIC)))
| > + return;
| > +
| > + panic("Out of memory: panic due to __GFP_PANIC.\n"
| > + "%s order:%d, mode:0x%x\n", current->comm,
| > + order, gfp_mask);
| > +}
|
| I think this just makes things harder to follow. It has one call-site so
| why not inline this there?
|

Indeed, will fix shortly, thanks.

-- Cyrill