Re: Lots of unexpected non-allocatable section warnings

[Jean Delvare <khali@linux-fr.org>]

Hi Sam,

On Sun, 3 May 2009 22:29:39 +0200, Sam Ravnborg wrote:
> This is due to the SUSE specific section as you expected.
> We ignore sections named ".comment" but not ".comment" sections
> with something appended to the name.
> 
> Can you please try appended patch and let me know if it fixes it for you.
> 
> Thanks,
> 	Sam
> 
> From 73aa9cbd4f71afdb173605383f77ebfda6d19ced Mon Sep 17 00:00:00 2001
> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Sun, 3 May 2009 22:17:37 +0200
> Subject: [PATCH 2/2] kbuild, modpost: fix "unexpected non-allocatable" warning with SUSE gcc
> 
> Jean reported that he saw one warning for each module like the one below:
> WARNING: arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.o (.comment.SUSE.OPTs): unexpected non-allocatable section.
> 
> The warning appeared with the improved version of the
> check of the flags in the sections.
> 
> That check already ignored sections named ".comment" - but SUSE store
> additional info in the comment section and has named it in a SUSE
> specific way. Therefore modpost failed to ignore the section.
> 
> The fix is to extend the pattern so we ignore all sections
> that start with the name ".comment.".
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Reported-by: Jean Delvare <khali@linux-fr.org>
> ---
>  scripts/mod/modpost.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index a5c17db..268d457 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -727,7 +727,7 @@ int match(const char *sym, const char * const pat[])
>  
>  /* sections that we do not want to do full section mismatch check on */
>  static const char *section_white_list[] =
> -	{ ".comment", ".debug*", ".stab*", ".note*", ".got*", ".toc*", NULL };
> +	{ ".comment*", ".debug*", ".stab*", ".note*", ".got*", ".toc*", NULL };
>  
>  /*
>   * This is used to find sections missing the SHF_ALLOC flag.

Yes, it fixes my problem. Thanks for the quick fix! Please push this
upstream quickly.

-- 
Jean Delvare