From: Andrea Righi <righi.andrea@gmail.com>
To: Ryo Tsuruta <ryov@valinux.co.jp>
Cc: linux-kernel@vger.kernel.org, dm-devel@redhat.com,
containers@lists.linux-foundation.org,
virtualization@lists.linux-foundation.org,
xen-devel@lists.xensource.com
Subject: Re: [PATCH 4/7] blkio-cgroup: The body of blkio-cgroup
Date: Mon, 4 May 2009 14:05:45 +0200 [thread overview]
Message-ID: <20090504120544.GA3986@linux> (raw)
In-Reply-To: <20090428.214604.104034341.ryov@valinux.co.jp>
On Tue, Apr 28, 2009 at 09:46:04PM +0900, Ryo Tsuruta wrote:
> The body of bio-cgroup.
>
> Based on 2.6.30-rc3-git3
> Signed-off-by: Hirokazu Takahashi <taka@valinux.co.jp>
> Signed-off-by: Ryo Tsuruta <ryov@valinux.co.jp>
Hi Ryo,
few minor coding style issues reported by checkpatch.pl:
WARNING: line over 80 characters
#138: FILE: include/linux/biotrack.h:67:
+static inline void blkio_cgroup_set_owner(struct page *page, struct mm_struct *mm)
WARNING: line over 80 characters
#152: FILE: include/linux/biotrack.h:81:
+static inline void blkio_cgroup_copy_owner(struct page *page, struct page *opage)
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#513: FILE: mm/biotrack.c:265:
+EXPORT_SYMBOL(get_blkio_cgroup_id);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#514: FILE: mm/biotrack.c:266:
+EXPORT_SYMBOL(blkio_cgroup_lookup);
total: 0 errors, 4 warnings, 515 lines checked
-Andrea
next prev parent reply other threads:[~2009-05-04 12:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 12:44 [PATCH 1/7] blkio-cgroup: Introduction Ryo Tsuruta
2009-04-28 12:44 ` [PATCH 2/7] blkio-cgroup: The new page_cgroup framework Ryo Tsuruta
2009-04-28 12:45 ` [PATCH 3/7] blkio-cgroup: Refactoring io-context initialization Ryo Tsuruta
2009-04-28 12:46 ` [PATCH 4/7] blkio-cgroup: The body of blkio-cgroup Ryo Tsuruta
2009-04-28 12:46 ` [PATCH 5/7] blkio-cgroup: Page tracking hooks Ryo Tsuruta
2009-04-28 12:47 ` [PATCH 6/7] blkio-cgroup: Add a cgroup support to dm-ioband Ryo Tsuruta
2009-04-28 12:47 ` [PATCH 7/7] blkio-cgroup: Fast page tracking Ryo Tsuruta
2009-05-04 12:05 ` Andrea Righi [this message]
2009-05-04 12:39 ` [PATCH 4/7] blkio-cgroup: The body of blkio-cgroup Alan Cox
2009-05-04 22:43 ` Ryo Tsuruta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090504120544.GA3986@linux \
--to=righi.andrea@gmail.com \
--cc=containers@lists.linux-foundation.org \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ryov@valinux.co.jp \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox