public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 6/6] ring-buffer: disable writers when resetting buffers
Date: Mon, 04 May 2009 11:19:39 -0400	[thread overview]
Message-ID: <20090504152021.349097001@goodmis.org> (raw)
In-Reply-To: 20090504151933.728781787@goodmis.org

[-- Attachment #1: 0006-ring-buffer-disable-writers-when-resetting-buffers.patch --]
[-- Type: text/plain, Size: 1092 bytes --]

From: Steven Rostedt <srostedt@redhat.com>

As a precaution, it is best to disable writing to the ring buffers
when reseting them.

[ Impact: prevent weird things if write happens during reset ]

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/trace/ring_buffer.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 7ff1f57..24372d1 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -2649,6 +2649,8 @@ void ring_buffer_reset_cpu(struct ring_buffer *buffer, int cpu)
 	if (!cpumask_test_cpu(cpu, buffer->cpumask))
 		return;
 
+	atomic_inc(&cpu_buffer->record_disabled);
+
 	spin_lock_irqsave(&cpu_buffer->reader_lock, flags);
 
 	__raw_spin_lock(&cpu_buffer->lock);
@@ -2658,6 +2660,8 @@ void ring_buffer_reset_cpu(struct ring_buffer *buffer, int cpu)
 	__raw_spin_unlock(&cpu_buffer->lock);
 
 	spin_unlock_irqrestore(&cpu_buffer->reader_lock, flags);
+
+	atomic_dec(&cpu_buffer->record_disabled);
 }
 EXPORT_SYMBOL_GPL(ring_buffer_reset_cpu);
 
-- 
1.6.2.4

-- 

      parent reply	other threads:[~2009-05-04 15:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-04 15:19 [PATCH 0/6] [GIT PULL v2] ring-buffer: speed ups Steven Rostedt
2009-05-04 15:19 ` [PATCH 1/6] ring-buffer: add counters for commit overrun and nmi dropped entries Steven Rostedt
2009-05-04 15:19 ` [PATCH 2/6] tracing: export stats of ring buffers to userspace Steven Rostedt
2009-05-04 15:19 ` [PATCH 3/6] ring-buffer: convert cpu buffer entries to local_t Steven Rostedt
2009-05-04 15:19 ` [PATCH 4/6] ring-buffer: record page entries in buffer page descriptor Steven Rostedt
2009-05-04 15:19 ` [PATCH 5/6] ring-buffer: have read page swap increment counter with page entries Steven Rostedt
2009-05-04 15:19 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090504152021.349097001@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox