From: Andrew Morton <akpm@linux-foundation.org>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: &&/|| typo?
Date: Mon, 4 May 2009 16:04:21 -0700 [thread overview]
Message-ID: <20090504160421.555dbb67.akpm@linux-foundation.org> (raw)
In-Reply-To: <49FCB137.8000003@gmail.com>
On Sat, 02 May 2009 22:46:47 +0200
Roel Kluin <roel.kluin@gmail.com> wrote:
> Subject: [PATCH] staging: &&/|| typo?
nit: if/when this driver gets moved out of staging/, it will still have
a commit titled "staging: &&/|| typo?" in its record.
That title will be pretty useless and meaningless for a driver which
isn't in staging!
So I'd suggest that in general, the "staging" information be included
inside [], so it gets tossed away as the patch is applied.
Also, the title is pretty bad in other ways - it doesn't identify what
part of the kernel is being changed. At least, not with sufficient
specificity.
So a better title would be, say,
[patch] [staging] wis-sony-tuner.c: fix &&/|| error
prev parent reply other threads:[~2009-05-04 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-02 20:46 [PATCH] staging: &&/|| typo? Roel Kluin
2009-05-04 23:04 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090504160421.555dbb67.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox