public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mel@csn.ul.ie>, LKML <linux-kernel@vger.kernel.org>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Rik van Riel <riel@redhat.com>,
	David Rientjes <rientjes@google.com>,
	Pavel Emelyanov <xemul@openvz.org>
Subject: Re: [PATCH -tip] mm: introduce __GFP_PANIC modifier
Date: Mon, 4 May 2009 23:11:11 +0400	[thread overview]
Message-ID: <20090504191111.GA31176@lenovo> (raw)
In-Reply-To: <alpine.DEB.1.10.0905041148490.10044@qirst.com>

[Christoph Lameter - Mon, May 04, 2009 at 11:54:53AM -0400]
| On Mon, 4 May 2009, Cyrill Gorcunov wrote:
| 
| > You know I only found a message in case if page is already
| > not granted (ie NULL is going to be returned) and right
| > before that we print a warning about that (nopage: label).
| > Which means - no panic here and with (__GFP_NOFAIL | __GFP_REPEAT)
| > just spinning around in attepmt to allocate new memory. And how
| > to behave on atomic allocations. Almost give up... :)
| 
| Could you check for __GFP_FAIL|__GFP_REPEAT somewheres and panic? Not sure
| if __GFP_REPEAT is the right second flag to use.
| 

Well Christoph I've checked those flags (and though for some
max fail iterations counter as well which was then refused).
None of combination seems to satisfy this requirement (don't
return NULL on out-of-memory but panic instead) in clear way.
There is a question remains opened how to behave on a case if
allocation was atomic. Just dunno.

If it is critical to not bring new __GFP_PANIC then
I could be just using __GFP_NOFAIL and nofity a user via
printk that we're in stage of allocating memory (anyway
it looks strange that we have a number of callers with
__GFP_NOFAIL with BUG_ON/if-checks following. But I could
me missing).

	-- Cyrill

  parent reply	other threads:[~2009-05-04 19:11 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-04 12:27 [PATCH -tip] mm: introduce __GFP_PANIC modifier Cyrill Gorcunov
2009-05-04 13:13 ` Ingo Molnar
2009-05-04 13:16   ` Cyrill Gorcunov
2009-05-04 13:47     ` Christoph Lameter
2009-05-04 14:12       ` Cyrill Gorcunov
2009-05-04 14:13         ` Christoph Lameter
2009-05-04 14:29           ` Cyrill Gorcunov
2009-05-04 15:20             ` Cyrill Gorcunov
2009-05-04 15:54               ` Christoph Lameter
2009-05-04 16:11                 ` Cyrill Gorcunov
2009-05-04 19:11                 ` Cyrill Gorcunov [this message]
2009-05-04 18:53       ` Andrew Morton
2009-05-04 19:21         ` Cyrill Gorcunov
2009-05-04 19:34           ` Andrew Morton
2009-05-04 20:09             ` Cyrill Gorcunov
2009-05-08 12:57               ` [RFC/PATCH v2] mm: Introduce GFP_PANIC for non-failing allocations Pekka Enberg
2009-05-08 13:37                 ` Cyrill Gorcunov
2009-05-08 13:50                   ` Pekka Enberg
2009-05-08 14:17                     ` Christoph Lameter
2009-05-08 14:20                 ` Christoph Lameter
2009-05-08 14:23                   ` Pekka Enberg
2009-05-08 14:29                     ` Christoph Lameter
2009-05-08 14:34                       ` Pekka Enberg
2009-05-08 14:37                         ` Rik van Riel
2009-05-08 14:39                           ` Pekka Enberg
2009-05-08 14:43                         ` Christoph Lameter
2009-05-04 19:23 ` [PATCH -tip] mm: introduce __GFP_PANIC modifier Mel Gorman
2009-05-04 19:35   ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090504191111.GA31176@lenovo \
    --to=gorcunov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mel@csn.ul.ie \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox