public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Tim Abbott <tabbott@MIT.EDU>, Steven Rostedt <srostedt@redhat.com>
Cc: Steven Rostedt <srostedt@redhat.com>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	Anders Kaseorg <andersk@MIT.EDU>, Waseem Daher <wdaher@MIT.EDU>,
	Denys Vlasenko <vda.linux@googlemail.com>,
	Jeff Arnold <jbarnold@MIT.EDU>
Subject: Re: [PATCH] ftrace: use .sched.text, not .text.sched in recordmcount.pl.
Date: Mon, 4 May 2009 21:30:33 +0200	[thread overview]
Message-ID: <20090504193033.GA10382@uranus.ravnborg.org> (raw)
In-Reply-To: <1241136371-10768-1-git-send-email-tabbott@mit.edu>

On Thu, Apr 30, 2009 at 08:06:11PM -0400, Tim Abbott wrote:
> The only references in the kernel to the .text.sched section are in
> recordmcount.pl.  Since the code it has is intended to be example code
> it should refer to real kernel sections.  So change it to .sched.text
> instead.
> 
> Signed-off-by: Tim Abbott <tabbott@mit.edu>
> Cc: Steven Rostedt <srostedt@redhat.com>

Steven - this change is independent of the ongoing
section rework and is a pure documentation fix.

Please apply it with my ack.

	Sam

[Kept whole patch for reference]

> ---
>  scripts/recordmcount.pl |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
> index 409596e..0fae7da 100755
> --- a/scripts/recordmcount.pl
> +++ b/scripts/recordmcount.pl
> @@ -26,7 +26,7 @@
>  # which will also be the location of that section after final link.
>  # e.g.
>  #
> -#  .section ".text.sched"
> +#  .section ".sched.text", "ax"
>  #  .globl my_func
>  #  my_func:
>  #        [...]
> @@ -39,7 +39,7 @@
>  #        [...]
>  #
>  # Both relocation offsets for the mcounts in the above example will be
> -# offset from .text.sched. If we make another file called tmp.s with:
> +# offset from .sched.text. If we make another file called tmp.s with:
>  #
>  #  .section __mcount_loc
>  #  .quad  my_func + 0x5
> @@ -51,7 +51,7 @@
>  # But this gets hard if my_func is not globl (a static function).
>  # In such a case we have:
>  #
> -#  .section ".text.sched"
> +#  .section ".sched.text", "ax"
>  #  my_func:
>  #        [...]
>  #        call mcount  (offset: 0x5)
> -- 
> 1.6.2.1
> 

  reply	other threads:[~2009-05-04 19:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-01  0:06 [PATCH] ftrace: use .sched.text, not .text.sched in recordmcount.pl Tim Abbott
2009-05-04 19:30 ` Sam Ravnborg [this message]
2009-05-04 19:35   ` Steven Rostedt
2009-05-06 12:18 ` [tip:tracing/core] " tip-bot for Tim Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090504193033.GA10382@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=andersk@MIT.EDU \
    --cc=jbarnold@MIT.EDU \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srostedt@redhat.com \
    --cc=tabbott@MIT.EDU \
    --cc=vda.linux@googlemail.com \
    --cc=wdaher@MIT.EDU \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox