From: Andrew Morton <akpm@linux-foundation.org>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM: suspend_device_irqs(): don't disable wakeup IRQs
Date: Mon, 4 May 2009 23:54:05 -0700 [thread overview]
Message-ID: <20090504235405.647772ed.akpm@linux-foundation.org> (raw)
In-Reply-To: <1241483224-7113-1-git-send-email-khilman@deeprootsystems.com>
On Mon, 4 May 2009 17:27:04 -0700 Kevin Hilman <khilman@deeprootsystems.com> wrote:
> Interrupts that are flagged as wakeup sources via set_irq_wake()
> should not be disabled for suspend.
>
Why not?
>
> diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
> index 638d8be..99113bd 100644
> --- a/kernel/irq/pm.c
> +++ b/kernel/irq/pm.c
> @@ -28,6 +28,9 @@ void suspend_device_irqs(void)
> for_each_irq_desc(irq, desc) {
> unsigned long flags;
>
> + if (desc->status & IRQ_WAKEUP)
> + continue;
> +
> spin_lock_irqsave(&desc->lock, flags);
> __disable_irq(desc, irq, true);
> spin_unlock_irqrestore(&desc->lock, flags);
If this fixes some bug then please provide a description of that bug?
next prev parent reply other threads:[~2009-05-05 6:56 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 0:27 [PATCH] PM: suspend_device_irqs(): don't disable wakeup IRQs Kevin Hilman
2009-05-05 6:54 ` Andrew Morton [this message]
2009-05-05 14:11 ` [linux-pm] " Vitaly Wool
2009-05-05 15:56 ` Kevin Hilman
2009-05-05 15:52 ` Kevin Hilman
2009-05-05 20:58 ` Arve Hjønnevåg
2009-05-05 23:15 ` Kevin Hilman
2009-05-05 23:27 ` Rafael J. Wysocki
2009-05-05 23:51 ` Arve Hjønnevåg
2009-05-06 0:13 ` Kevin Hilman
2009-05-06 0:38 ` Kevin Hilman
2009-05-06 0:45 ` Kevin Hilman
2009-05-06 14:04 ` Kevin Hilman
2009-05-06 21:18 ` Rafael J. Wysocki
2009-05-07 0:16 ` Kevin Hilman
2009-05-07 1:18 ` Arve Hjønnevåg
2009-05-07 1:28 ` Kim Kyuwon
2009-05-07 1:44 ` Arve Hjønnevåg
2009-05-07 2:04 ` Kim Kyuwon
2009-05-07 14:13 ` Kevin Hilman
2009-05-07 11:54 ` Rafael J. Wysocki
2009-05-06 0:20 ` Kim Kyuwon
2009-05-22 2:53 ` Kim Kyuwon
2009-05-22 16:04 ` Kim Kyuwon
2009-05-22 21:25 ` Rafael J. Wysocki
2009-05-22 22:32 ` Kim Kyuwon
2009-05-22 23:47 ` Rafael J. Wysocki
2009-05-23 0:42 ` Kim Kyuwon
2009-05-22 21:23 ` Rafael J. Wysocki
2009-05-22 22:24 ` Kim Kyuwon
2009-05-22 22:29 ` Rafael J. Wysocki
2009-05-22 23:03 ` Kim Kyuwon
2009-05-23 20:14 ` Rafael J. Wysocki
2009-05-25 7:02 ` Kim Kyuwon
2009-05-29 23:35 ` Rafael J. Wysocki
2009-05-30 7:34 ` Kim Kyuwon
2009-05-30 7:40 ` Kim Kyuwon
2009-05-30 21:00 ` Rafael J. Wysocki
2009-05-05 23:57 ` Arve Hjønnevåg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090504235405.647772ed.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox