From: Jarod Wilson <jarod@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH] crypto: add ctr(aes) test vectors
Date: Tue, 5 May 2009 09:55:24 -0400 [thread overview]
Message-ID: <200905050955.24743.jarod@redhat.com> (raw)
In-Reply-To: <20090505131835.GA18659@gondor.apana.org.au>
On Tuesday 05 May 2009 09:18:35 Herbert Xu wrote:
> On Mon, May 04, 2009 at 04:24:44PM -0400, Jarod Wilson wrote:
> >
> > Indeed, the first enc/dec operation after we set the counter *is*
> > completely deterministic across all implementations, the AESAVS
> > is referring to tests with multiple operations, which aren't
> > possible, due to varying implementations of counter increment
> > routines. This patch adds test vectors for ctr(aes), using the
> > first block input values from Appendix F.5 of NIST Special Pub
> > 800-38A.
>
> Well, our ctr(aes) must be completely deterministic as it is
> used as the base for CCM and GCM. In fact, if it weren't so
> then you can't use it for anything since two implementations
> may produces different outputs.
Yeah, that makes sense, I believe I finally see the light.
> So if you could resend some vectors that test multiple blocks
> then I'll happily add them.
Multi-block test vectors coming shortly, passing in all the input
blocks from F.5 of 800-38A is spitting back the expected answers
for ever block.
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2009-05-05 13:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 1:18 [PATCH] crypto: don't raise alarm for no ctr(aes*) tests in fips mode Jarod Wilson
2009-04-29 10:50 ` Neil Horman
2009-04-29 12:46 ` Jarod Wilson
2009-04-30 21:13 ` [PATCH v2] crypto: don't raise alarm for no ctr(aes) tests Jarod Wilson
2009-05-01 11:54 ` Neil Horman
2009-05-04 11:10 ` [PATCH] crypto: don't raise alarm for no ctr(aes*) tests in fips mode Herbert Xu
2009-05-04 18:56 ` Jarod Wilson
2009-05-05 1:08 ` Herbert Xu
2009-05-05 3:45 ` Jarod Wilson
2009-05-05 5:29 ` Herbert Xu
2009-05-05 13:04 ` Jarod Wilson
2009-05-04 20:24 ` [PATCH] crypto: add ctr(aes) test vectors Jarod Wilson
2009-05-05 13:18 ` Herbert Xu
2009-05-05 13:55 ` Jarod Wilson [this message]
2009-05-05 14:42 ` [PATCH v2] " Jarod Wilson
2009-05-06 9:30 ` Herbert Xu
2009-05-06 12:51 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905050955.24743.jarod@redhat.com \
--to=jarod@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox