Re: [PATCH 09/21] amd64_edac: assign DRAM chip select base and mask in a family-specific way

[Borislav Petkov <borislav.petkov@amd.com>]

On Mon, May 04, 2009 at 06:59:14PM -0300, Mauro Carvalho Chehab wrote:
> Borislav Petkov escreveu:
>> +	for (cs = 0; cs < CHIPSELECT_COUNT; cs++) {
>> +		reg = K8_DCSB0 + (cs * 4);
>> +		err = pci_read_config_dword(pvt->dram_f2_ctl, reg,
>> +						&pvt->dcsb0[cs]);
>> +		if (err != 0)
>> +			debugf0("%s() Reading K8_DCSB0[%d] failed\n",
>> +				__func__, cs);
>> +
>> +		debugf0("  DCSB0[%d]=0x%08x reg: F2x%x\n",
>> +			cs, pvt->dcsb0[cs], reg);
>>   
>
> Hmm... I suspect that there's a missing else before the debugf0(). If  
> you got an error while reading it, you shouldn't be showing the results. 
>> +
>> +		/* If DCT are NOT ganged, then read in DCT1's base */
>> +		if (boot_cpu_data.x86 >= 0x10 && !dct_ganging_enabled(pvt)) {
>> +			reg = F10_DCSB1 + (cs * 4);
>> +			err = pci_read_config_dword(pvt->dram_f2_ctl, reg,
>> +							&pvt->dcsb1[cs]);
>> +			if (err != 0)
>> +				debugf0("%s() Reading F10_DCSB1[%d] failed\n",
>> +					__func__, cs);
>> +			debugf0("  DCSB1[%d]=0x%08x reg: F2x%x\n",
>> +				cs, pvt->dcsb1[cs], reg);
>>   
> The same issue here: if you got an error while reading it, you shouldn't  
> be showing the results. 

correct, thanks.

-- 
Regards/Gruss,
Boris.

Operating | Advanced Micro Devices GmbH
  System  | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
 Research | Geschäftsführer: Thomas M. McCoy, Giuliano Meroni
  Center  | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
  (OSRC)  | Registergericht München, HRB Nr. 43632