Re: [Security] [PATCH] proc: avoid information leaks to non-privileged processes

[Matt Mackall <mpm@selenic.com>]

On Tue, May 05, 2009 at 08:35:35AM -0700, Linus Torvalds wrote:
> 
> 
> On Tue, 5 May 2009, Linus Torvalds wrote:
> > 
> > Note: the "pid + jiffies" is just meant to be a tiny tiny bit of noise. It 
> > has no real meaning. It could be anything. I just picked the previous 
> > seed, it's just that now we keep the state in between calls and that will 
> > feed into the next result, and that should make all the difference.
> 
> Actually, thinking about it, we could/should probably just remove that 
> tiny bit of noise.
> 
> After all, we get _real_ noise from the "keyptr->secret" thing. It's not 
> updated all the time, but it's certainly updated often enough that nobody 
> will ever see anything remotely guessable, I suspect.
> 
> Not that the "pid+jiffies" should hurt either, of course. It just doesn't 
> really look meaningful, and only exists as a historical oddity that 
> relates to the previous implementation of get_random_int().

I think it can only do good here. Recursively applied functions are
vulnerable to falling into greatly reduced state spaces (see 'strange
attractors') and adding any old crap can perturb it out of those
spaces. A good hash function should be resistant to this, but MD4 and
half_MD4 are not good hash functions.

-- 
Mathematics is the supreme nostalgia of our time.