Re: [PATCH 2.6.29.2] PXA I2C: Define log level for i2c PXA error report

Jean Delvare
2009-05-11T08:56:38Z

On Mon, 11 May 2009 07:38:59 +0100 (BST), Michael Abbott wrote:
> On Wed, 6 May 2009, Jean Delvare wrote:
> > On Wed, 6 May 2009 08:32:09 +0100 (BST), Michael Abbott wrote:
> > > All the i2c pxa error messages should probably be KERN_DEBUG
> > >
> > > At least, all the printk messages should have a log level specfied,
> > > and KERN_DEBUG seems appropriate.
> > >
> > > Signed-off-by: Michael Abbott <michael.abbott@diamond.ac.uk>
> > > ---
> > > drivers/i2c/busses/i2c-pxa.c | 8 ++++----
> > > 1 files changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
> > > index bdb1f75..8cb9160 100644
> > > --- a/drivers/i2c/busses/i2c-pxa.c
> > > +++ b/drivers/i2c/busses/i2c-pxa.c
> > > @@ -210,11 +210,11 @@ static irqreturn_t i2c_pxa_handler(int this_irq, void *dev_id);
> > > static void i2c_pxa_scream_blue_murder(struct pxa_i2c *i2c, const char *why)
> > > {
> > > unsigned int i;
> > > - printk("i2c: error: %s\n", why);
> > > - printk("i2c: msg_num: %d msg_idx: %d msg_ptr: %d\n",
> > > + printk(KERN_DEBUG "i2c: error: %s\n", why);
> > > + printk(KERN_DEBUG "i2c: msg_num: %d msg_idx: %d msg_ptr: %d\n",
> > > i2c->msg_num, i2c->msg_idx, i2c->msg_ptr);
> > > - printk("i2c: ICR: %08x ISR: %08x\n"
> > > - "i2c: log: ", readl(_ICR(i2c)), readl(_ISR(i2c)));
> > > + printk(KERN_DEBUG "i2c: ICR: %08x ISR: %08x\n"
> > > + KERN_DEBUG "i2c: log: ", readl(_ICR(i2c)), readl(_ISR(i2c)));
> > > for (i = 0; i < i2c->irqlogidx; i++)
> > > printk("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]);
> > > printk("\n");
> >
> > Already fixed in Linus' tree:
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=154d22b04ae1741c5fcfd5d747b813a9a279abff#patch4
>
> Now this is very odd. I'd assumed the error messages I was getting were
> just noise, but the commit you point me to uses KERN_ERR instead -- and so
> I get a brief storm of these messages on boot on my target:
>
> [ 20.667923] i2c: error: exhausted retries
> [ 20.671962] i2c: msg_num: 0 msg_idx: -2000 msg_ptr: 0
> [ 20.677113] i2c: ICR: 000007e0 ISR: 00000002
> [ 20.677128] i2c: log: [00000446:000007e0]
>
> This is repeated nine times in total with exactly the same numbers. Any
> thoughts as to what this means? Other than these messages on startup my
> I2C sensors seem to work perfectly well.

I don't know anything about the i2c-pxa driver, sorry.

--
Jean Delvare