public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: rostedt@goodmis.org, mingo@elte.hu, lethal@linux-sh.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] sh: remove stray markers
Date: Wed, 6 May 2009 12:38:54 +0200	[thread overview]
Message-ID: <20090506103854.GA23811@lst.de> (raw)

arch/sh has a couple of stray markers without any users introduced
in commit 3d58695edbfac785161bf282dc11fd42a483d6c9.  Remove them in
preparation of removing the markers in favour of the TRACE_EVENT
macro (and also because we don't keep dead code around).

Paul, are you okay putting this in via the tracing tree?  I'd like
to have all marker removals queued up there so we can kill it in one
go once 2.6.31 opens.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6-tip/arch/sh/kernel/process_32.c
===================================================================
--- linux-2.6-tip.orig/arch/sh/kernel/process_32.c	2009-05-06 10:35:22.000000000 +0000
+++ linux-2.6-tip/arch/sh/kernel/process_32.c	2009-05-06 10:35:25.000000000 +0000
@@ -119,8 +119,6 @@
 	pid = do_fork(flags | CLONE_VM | CLONE_UNTRACED, 0,
 		      &regs, 0, NULL, NULL);
 
-	trace_mark(kernel_arch_kthread_create, "pid %d fn %p", pid, fn);
-
 	return pid;
 }
 
Index: linux-2.6-tip/arch/sh/kernel/process_64.c
===================================================================
--- linux-2.6-tip.orig/arch/sh/kernel/process_64.c	2009-05-06 10:35:22.000000000 +0000
+++ linux-2.6-tip/arch/sh/kernel/process_64.c	2009-05-06 10:35:36.000000000 +0000
@@ -323,7 +323,6 @@
 int kernel_thread(int (*fn)(void *), void * arg, unsigned long flags)
 {
 	struct pt_regs regs;
-	int pid;
 
 	memset(&regs, 0, sizeof(regs));
 	regs.regs[2] = (unsigned long)arg;
@@ -333,12 +332,8 @@
 	regs.sr = (1 << 30);
 
 	/* Ok, create the new process.. */
-	pid = do_fork(flags | CLONE_VM | CLONE_UNTRACED, 0,
+	return do_fork(flags | CLONE_VM | CLONE_UNTRACED, 0,
 		      &regs, 0, NULL, NULL);
-
-	trace_mark(kernel_arch_kthread_create, "pid %d fn %p", pid, fn);
-
-	return pid;
 }
 
 /*
Index: linux-2.6-tip/arch/sh/kernel/sys_sh.c
===================================================================
--- linux-2.6-tip.orig/arch/sh/kernel/sys_sh.c	2009-05-06 10:35:22.000000000 +0000
+++ linux-2.6-tip/arch/sh/kernel/sys_sh.c	2009-05-06 10:35:41.000000000 +0000
@@ -79,8 +79,6 @@
 	version = call >> 16; /* hack for backward compatibility */
 	call &= 0xffff;
 
-	trace_mark(kernel_arch_ipc_call, "call %u first %d", call, first);
-
 	if (call <= SEMTIMEDOP)
 		switch (call) {
 		case SEMOP:
Index: linux-2.6-tip/arch/sh/mm/fault_32.c
===================================================================
--- linux-2.6-tip.orig/arch/sh/mm/fault_32.c	2009-05-06 10:35:22.000000000 +0000
+++ linux-2.6-tip/arch/sh/mm/fault_32.c	2009-05-06 10:35:59.000000000 +0000
@@ -249,9 +249,6 @@
 {
 	int ret = 0;
 
-	trace_mark(kernel_arch_trap_entry, "trap_id %d ip #p%ld",
-		   trap >> 5, instruction_pointer(regs));
-
 #ifdef CONFIG_KPROBES
 	if (!user_mode(regs)) {
 		preempt_disable();
@@ -327,6 +324,5 @@
 
 	ret = 0;
 out:
-	trace_mark(kernel_arch_trap_exit, MARK_NOARGS);
 	return ret;
 }

             reply	other threads:[~2009-05-06 10:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-06 10:38 Christoph Hellwig [this message]
2009-05-06 11:07 ` [PATCH] sh: remove stray markers Ingo Molnar
2009-05-06 11:12   ` Christoph Hellwig
2009-05-06 11:15     ` Ingo Molnar
2009-05-07  2:04       ` Paul Mundt
2009-05-07  7:30         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090506103854.GA23811@lst.de \
    --to=hch@lst.de \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox