Re: [patch 57/58] tracing: x86, mmiotrace: fix range test

Steven Rostedt
2009-05-06T22:22:25Z

On Wed, 6 May 2009, Greg KH wrote:

> 2.6.29-stable review patch. If anyone has any objections, please let us know.
>
> ------------------
>
> From: Stuart Bennett <stuart@freedesktop.org>
>
> commit 33015c85995716d03f6293346cf05a1908b0fb9a upstream.
>
> Matching on (addr == (p->addr + p->len)) causes problems when mappings
> are adjacent.
>
> [ Impact: fix mmiotrace confusion on adjacent iomaps ]
>
> Signed-off-by: Stuart Bennett <stuart@freedesktop.org>
> Acked-by: Pekka Paalanen <pq@iki.fi>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> LKML-Reference: <1240946271-7083-2-git-send-email-stuart@freedesktop.org>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

>
> ---
> arch/x86/mm/kmmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/mm/kmmio.c
> +++ b/arch/x86/mm/kmmio.c
> @@ -87,7 +87,7 @@ static struct kmmio_probe *get_kmmio_pro
> {
> struct kmmio_probe *p;
> list_for_each_entry_rcu(p, &kmmio_probes, list) {
> - if (addr >= p->addr && addr <= (p->addr + p->len))
> + if (addr >= p->addr && addr < (p->addr + p->len))
> return p;
> }
> return NULL;
>
>
>