public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org, niv@us.ibm.com, dvhltc@us.ibm.com,
	lethal@linux-sh.org, kernel@wantstofly.org, matthew@wil.cx
Subject: Re: [PATCH] v4 RCU: the bloatwatch edition
Date: Wed, 6 May 2009 15:51:15 -0700	[thread overview]
Message-ID: <20090506225115.GM6771@linux.vnet.ibm.com> (raw)
In-Reply-To: <11979.1241648574@redhat.com>

On Wed, May 06, 2009 at 11:22:54PM +0100, David Howells wrote:
> Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> > More like "concerns".  It's unobvious to me that the modest .text
> > savings justify the costs of an additional RCU implementation.  Where
> > those costs include
> 
> It may be more than just modest .text savings.  Being optimised to be as
> simple as possible, and to only support one CPU, it may be quicker too.  I'm
> not sure how best to benchmark it though.

The read side is unchanged, but the update side is another story, given
that synchronize_rcu()'s latency decreases from multiple milliseconds
to the sub-microsecond range:

	void synchronize_rcu(void)
	{
		unsigned long flags;

		local_irq_save(flags);
		rcu_ctrlblk.completed++;
		local_irq_restore(flags);
	}

So boot speed is one possible metric, depending on how many synchronize_rcu()
invocations are in your arch's boot path.  It appears that x86 has a
fair number.  ;-)

							Thanx, Paul

  reply	other threads:[~2009-05-06 22:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-02 16:34 [PATCH] v4 RCU: the bloatwatch edition Paul E. McKenney
2009-05-05 21:18 ` David Howells
2009-05-06 12:09   ` Ingo Molnar
2009-05-06 18:24     ` Andrew Morton
2009-05-06 19:02       ` Paul E. McKenney
2009-05-06 19:19         ` Andrew Morton
2009-05-06 20:20           ` Paul E. McKenney
2009-05-06 22:22       ` David Howells
2009-05-06 22:51         ` Paul E. McKenney [this message]
2009-06-22 11:43           ` David Howells
2009-06-22 12:49             ` Ingo Molnar
2009-06-22 15:29               ` Andrew Morton
2009-06-22 16:07                 ` Paul E. McKenney
2009-06-22 16:15                   ` David Howells
2009-06-22 18:09                     ` Paul E. McKenney
2009-06-22 16:30                   ` Darren Hart
2009-06-22 17:08                     ` Paul E. McKenney
2009-06-23  9:48                       ` Ingo Molnar
2009-06-23 12:59                         ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090506225115.GM6771@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=dvhltc@us.ibm.com \
    --cc=kernel@wantstofly.org \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=niv@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox