Re: [PATCH] w1-gpio: add external pull-up enable callback

[Daniel Mack <daniel@caiaq.de>]

On Wed, May 06, 2009 at 11:28:18PM +0300, Ville Syrjälä wrote:
> > > > This patch adds a callback function pointer to let users switch on and
> > > > off the external pull-up resistor. This lets the outside world know
> > > > whether the processor is currently actively driving the bus or not.
> > > 
> > > Looks simple enough but I wonder if you could just do this from the
> > > platform code. I suppose the downside would be that you would enable the
> > > pullup even if w1-gpio is not loaded.
> > 
> > That's right. Hence I put it where I believe it belongs to.
> 
> Well, if you think you need it who am I to argue :)
> 
> Acked-by: Ville Syrjälä <syrjala@sci.fi>

Thanks :)

Daniel