From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761033AbZEGBap (ORCPT ); Wed, 6 May 2009 21:30:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753921AbZEGBag (ORCPT ); Wed, 6 May 2009 21:30:36 -0400 Received: from buzzloop.caiaq.de ([212.112.241.133]:48258 "EHLO buzzloop.caiaq.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752375AbZEGBaf (ORCPT ); Wed, 6 May 2009 21:30:35 -0400 Date: Thu, 7 May 2009 03:30:32 +0200 From: Daniel Mack To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , linux-kernel@vger.kernel.org Subject: Re: [PATCH] w1-gpio: add external pull-up enable callback Message-ID: <20090507013032.GA5456@buzzloop.caiaq.de> References: <1241527413-22920-1-git-send-email-daniel@caiaq.de> <20090506093307.GC17782@sci.fi> <20090506093445.GA31875@buzzloop.caiaq.de> <20090506202818.GH17782@sci.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20090506202818.GH17782@sci.fi> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 06, 2009 at 11:28:18PM +0300, Ville Syrjälä wrote: > > > > This patch adds a callback function pointer to let users switch on and > > > > off the external pull-up resistor. This lets the outside world know > > > > whether the processor is currently actively driving the bus or not. > > > > > > Looks simple enough but I wonder if you could just do this from the > > > platform code. I suppose the downside would be that you would enable the > > > pullup even if w1-gpio is not loaded. > > > > That's right. Hence I put it where I believe it belongs to. > > Well, if you think you need it who am I to argue :) > > Acked-by: Ville Syrjälä Thanks :) Daniel