From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760282AbZEGONr (ORCPT ); Thu, 7 May 2009 10:13:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753469AbZEGONh (ORCPT ); Thu, 7 May 2009 10:13:37 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:57393 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752606AbZEGONf (ORCPT ); Thu, 7 May 2009 10:13:35 -0400 Date: Thu, 7 May 2009 16:12:22 +0200 From: Ingo Molnar To: Yinghai Lu Cc: Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , Jesse Barnes , Len Brown , "linux-kernel@vger.kernel.org" , linux-pci@vger.kernel.org, ACPI Devel Maling List Subject: Re: [PATCH 7/7] x86/pci: update pirq_enable_irq to setup io apic routing -v2 Message-ID: <20090507141222.GI481@elte.hu> References: <4A01C35C.7060207@kernel.org> <4A01C46E.8000501@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A01C46E.8000501@kernel.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yinghai Lu wrote: > > so we could set io apic routing only when enable device irq. > > also could make setup_IO_APIC_irqs and setup_ioapic_dest only handle > first ioapic... > > v2: remove one one not needed style change. > merge the patch only setup io_apic for acpi on in setup_IO_APIC_irqs > > [ Impact: make mptable irq enable more like acpi is used, and numa_irq_desc could get correct node when acpi=off ] > > Signed-off-by: Yinghai Lu > > --- > arch/x86/kernel/apic/io_apic.c | 148 ++++++++++++++++++++--------------------- > arch/x86/pci/irq.c | 84 ++++++++--------------- > 2 files changed, 103 insertions(+), 129 deletions(-) Jesse, did this patch have your Acked-by? Ingo