public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jarod Wilson <jarod@redhat.com>
To: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Neil Horman <nhorman@tuxdriver.com>
Subject: [PATCH 0/2] crypto: disallow non-approved algs in fips mode
Date: Thu, 7 May 2009 14:41:26 -0400	[thread overview]
Message-ID: <200905071441.27093.jarod@redhat.com> (raw)

At present, nothing is preventing the use of non-approved algorithms
in fips mode. I was initially working on a patch to make it easier
for all fips-approved algs to be tested using tcrypt, and realized
the changes I was making could also be used to prevent non-approved
algs in fips mode. Any approved alg *must* have self-tests, and thus
have an entry in testmgr.c's alg_test_descs[]. By adding a fips flag
to these entries, we can simply reject all algs that don't have this
flag when in fips mode by skipping their self-tests and returning
an -EINVAL to prevent them from being loaded. So with this change, I
can

1) 'modprobe tcrypt' and have all fips approved algs self-tested, and
   *only* fips approved algs tested

2) 'modprobe md4' for example, and in fips mode, have the module load
   rejected as invalid

Patch 1/2 adds the basic infra
Patch 2/2 marks the allowed algs

-- 
Jarod Wilson
jarod@redhat.com

             reply	other threads:[~2009-05-07 18:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-07 18:41 Jarod Wilson [this message]
2009-05-07 19:27 ` [PATCH 0/2] crypto: disallow non-approved algs in fips mode Jarod Wilson
2009-05-07 19:27 ` [PATCH 1/2] crypto: add infra to skip disallowed " Jarod Wilson
2009-05-08  2:12   ` Herbert Xu
2009-05-08  4:51     ` Jarod Wilson
2009-05-08  4:55     ` [PATCH 1/2] crypto: mark algs allowed " Jarod Wilson
2009-05-15  5:17       ` Herbert Xu
2009-05-08  5:00     ` [PATCH 2/2] crypto: skip algs not flagged fips_allowed " Jarod Wilson
2009-05-07 19:28 ` [PATCH 2/2] crypto: mark algs allowed " Jarod Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905071441.27093.jarod@redhat.com \
    --to=jarod@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox