From: Andi Kleen <andi@firstfloor.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86 MCE: shut up lockdep warning
Date: Fri, 8 May 2009 08:45:17 +0200 [thread overview]
Message-ID: <20090508064517.GX23223@one.firstfloor.org> (raw)
In-Reply-To: <1241754429.4444.12.camel@sli10-desk.sh.intel.com>
On Fri, May 08, 2009 at 11:47:09AM +0800, Shaohua Li wrote:
> lockdep report below warning when I try to offline one cpu:
> [ 110.835487] =================================
> [ 110.835616] [ INFO: inconsistent lock state ]
> [ 110.835688] 2.6.30-rc4-00336-g8c9ed89 #52
> [ 110.835757] ---------------------------------
> [ 110.835828] inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage.
> [ 110.835908] swapper/0 [HC1[1]:SC0[0]:HE0:SE1] takes:
> [ 110.835982] (cmci_discover_lock){?.+...}, at: [<ffffffff80236dc0>] cmci_clear+0x30/0x9b
>
> smp_call_function_single() will disable interrupt. moving mce reenable/disable
> to workqueue, so no irq is disabled.
Looks good. Thanks.
Acked-by: Andi Kleen <ak@linux.intel.com>
>
> Signed-off-by: Shaohua Li<shaohua.li@intel.com>
-Andi
next prev parent reply other threads:[~2009-05-08 6:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 3:47 [PATCH] x86 MCE: shut up lockdep warning Shaohua Li
2009-05-08 6:45 ` Andi Kleen [this message]
2009-05-08 9:10 ` Ingo Molnar
2009-05-08 9:37 ` Andi Kleen
2009-05-08 12:14 ` Shaohua Li
2009-05-08 8:17 ` Hidetoshi Seto
2009-05-08 8:28 ` [PATCH] x86 MCE: yet another " Hidetoshi Seto
2009-05-08 9:07 ` [tip:x86/urgent] x86: MCE: make cmci_discover_lock irq-safe tip-bot for Hidetoshi Seto
2009-05-08 8:34 ` [PATCH] x86 MCE: shut up lockdep warning Peter Zijlstra
2009-05-08 19:11 ` Andi Kleen
2009-05-08 9:04 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090508064517.GX23223@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox