From: Rusty Russell <rusty@rustcorp.com.au>
To: virtualization@lists.linux-foundation.org
Cc: Sheng Yang <sheng@linux.intel.com>,
Matthew Wilcox <matthew@wil.cx>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
jbarnes@virtuousgeek.org, Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH] msi-x: let drivers retry when not enough vectors
Date: Fri, 8 May 2009 09:25:00 +0930 [thread overview]
Message-ID: <200905080925.01398.rusty@rustcorp.com.au> (raw)
In-Reply-To: <200905071819.54426.sheng@linux.intel.com>
On Thu, 7 May 2009 07:49:53 pm Sheng Yang wrote:
> On Thursday 07 May 2009 17:53:02 Matthew Wilcox wrote:
> > Here's a good example. Let's suppose you have a driver which supports
> > two different models of cards, one has 16 MSI-X interrupts, the other
> > has 10. You can call pci_enable_msix() asking for 16 vectors. If your
> > card is model A, you get 16 interrupts. If your card is model B, it says
> > "you can have 10".
Sheng is absolutely right, that's a horrid API.
If it actually enabled that number and returned it, it might make sense (cf.
write() returning less bytes than you give it). But overloading the return
value to save an explicit call is just ugly; it's not worth saving a few lines
of code at cost of making all the drivers subtle and tricksy.
Fail with -ENOSPC or something.
Rusty.
next prev parent reply other threads:[~2009-05-07 23:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 8:28 [PATCH] msi-x: let drivers retry when not enough vectors Michael S. Tsirkin
2009-05-07 8:51 ` Sheng Yang
2009-05-07 9:05 ` Michael S. Tsirkin
2009-05-07 9:10 ` Sheng Yang
2009-05-07 9:31 ` Michael S. Tsirkin
2009-05-07 9:27 ` Matthew Wilcox
2009-05-07 9:40 ` Sheng Yang
2009-05-07 9:53 ` Matthew Wilcox
2009-05-07 10:19 ` Sheng Yang
2009-05-07 10:32 ` Michael S. Tsirkin
2009-05-07 23:55 ` Rusty Russell [this message]
2009-05-08 0:22 ` Matthew Wilcox
2009-05-08 0:28 ` Michael Ellerman
2009-05-12 21:28 ` Michael S. Tsirkin
2009-05-07 10:23 ` Michael Ellerman
2009-05-07 10:28 ` Sheng Yang
2009-05-07 10:44 ` Avi Kivity
2009-05-07 11:57 ` Matthew Wilcox
2009-06-11 18:28 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905080925.01398.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=jbarnes@virtuousgeek.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mst@redhat.com \
--cc=sheng@linux.intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox