Re: [PATCH 0/3] x86: adapt CPU topology detection for AMD Magny-Cours

[Andreas Herrmann <andreas.herrmann3@amd.com>]

On Mon, May 04, 2009 at 07:33:30PM +0200, Andreas Herrmann wrote:
> For all cores on the same multi-node CPU (Magny-Cours) /proc/cpuinfo
> will show:
> - same phys_proc_id
> - cpu_node_id of the internal node (0 or 1)
> - cpu_core_id (e.g. in range of 0 to 5)

Are there further objections (besides Andi's) to show cpu_node_id
in /proc/cpuinfo?

As I've written in another mail I also plan to introduce
cpu_node_siblings and expose this information in
/sys/devices/system/cpu/cpuX/topology

That would mean:
- for single-node processors node_siblings are equal to
  core_siblings.
- for dual-node processors node_siblings is the union of
  two sets of core_siblings (one set on each node).

Any objections/comments? Should I use some other naming instead of node?
Node means a set of cores plus a northbirdge and memory controller.
But maybe I should use chip instead of node (chip_siblings, cpu_chip_id,
etc.)? This would be in dependence on multi-CHIP module.

> Patches are against tip/master as of today.
> Please consider patches 1 and 2 for .30.

I guess it's way too late to add something like this for .30, right?
So I'll prepare some new patches and try to hit .31.


Thanks,
Andreas

-- 
Operating | Advanced Micro Devices GmbH
  System  | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
 Research | Geschäftsführer: Thomas M. McCoy, Giuliano Meroni
  Center  | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
  (OSRC)  | Registergericht München, HRB Nr. 43632