Re: [PATCH] groups: move code to kernel/groups.c

[Ingo Molnar <mingo@elte.hu>]

* Alexey Dobriyan <adobriyan@gmail.com> wrote:

> Move supplementary groups implementation to kernel/groups.c .
> kernel/sys.c already accumulated quite a few random stuff.
> 
> Do strictly copy/paste + add required headers to compile.
> Compile-tested on many configs and archs.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  kernel/Makefile |    1 
>  kernel/groups.c |  288 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  kernel/sys.c    |  283 -------------------------------------------------------
>  3 files changed, 289 insertions(+), 283 deletions(-)

If you touch this code (which code has not been touched for years), 
do it only if you are also willing to do a followup patch that fixes 
most of these checkpatch warnings:

  total: 1 errors, 9 warnings, 0 checks, 584 lines checked

(Most of these are valid - and there's some other low hanging fruits 
as well which you will notice if you read the file.)

When creating a new file in kernel/ there's just no excuse for not 
doing it cleanly.

Thanks,

	Ingo