From: Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Andrew Morton <akpm@linux-foundation.org>,
gorcunov@openvz.org, kosaki.motohiro@jp.fujitsu.com,
mel@csn.ul.ie, cl@linux-foundation.org, riel@redhat.com,
linux-kernel@vger.kernel.org, rientjes@google.com
Subject: Re: [PATCH 1/2] mm: Introduce GFP_PANIC for early-boot allocations
Date: Sat, 9 May 2009 11:32:49 +0200 [thread overview]
Message-ID: <20090509093249.GA4874@elte.hu> (raw)
In-Reply-To: <20090509091911.GA13784@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> it is shorter, tidier, more maintainable, more reviewable to write:
>
> ptr = kmalloc(GFP_BOOT, size);
>
> than to write:
>
> ptr = kmalloc(GFP_KERNEL, size);
> BUG_ON(!ptr);
[ Oh, and everyone saw the kernel bug i hid, and did notice it in
the first variant sooner than in the second, right? :) ]
Ingo
next prev parent reply other threads:[~2009-05-09 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 15:10 [PATCH 1/2] mm: Introduce GFP_PANIC for early-boot allocations Pekka Enberg
2009-05-08 15:29 ` Christoph Lameter
2009-05-08 15:41 ` Pekka Enberg
2009-05-09 8:31 ` Ingo Molnar
2009-05-08 20:56 ` Andrew Morton
2009-05-09 8:39 ` Pekka Enberg
2009-05-09 9:19 ` Ingo Molnar
2009-05-09 9:19 ` Pekka Enberg
2009-05-09 9:31 ` Ingo Molnar
2009-05-09 9:32 ` Ingo Molnar [this message]
2009-05-10 3:34 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090509093249.GA4874@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=gorcunov@openvz.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=penberg@cs.helsinki.fi \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox