[PATCH] x86: Fix false positive section mismatch in apic.

[PATCH] x86: Fix false positive section mismatch in apic.

[Rakib Mullick]

 Sorry guys , for being late. My system was out of order for a week.


 x86: Fix false positive section mismatch warnings in the apic code

----
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>

--- linus/arch/x86/kernel/apic/es7000_32.c	2009-05-08 07:03:07.000000000 +0600
+++ rakib/arch/x86/kernel/apic/es7000_32.c	2009-05-07 20:38:06.000000000 +0600
@@ -254,7 +254,7 @@ static int parse_unisys_oem(char *oemptr
 }

 #ifdef CONFIG_ACPI
-static int find_unisys_acpi_oem_table(unsigned long *oem_addr)
+static int __init find_unisys_acpi_oem_table(unsigned long *oem_addr)
 {
 	struct acpi_table_header *header = NULL;
 	struct es7000_oem_table *table;
@@ -285,7 +285,7 @@ static int find_unisys_acpi_oem_table(un
 	return 0;
 }

-static void unmap_unisys_acpi_oem_table(unsigned long oem_addr)
+static void __init unmap_unisys_acpi_oem_table(unsigned long oem_addr)
 {
 	if (!oem_addr)
 		return;
@@ -306,7 +306,7 @@ static int es7000_check_dsdt(void)
 static int es7000_acpi_ret;

 /* Hook from generic ACPI tables.c */
-static int es7000_acpi_madt_oem_check(char *oem_id, char *oem_table_id)
+static int __init es7000_acpi_madt_oem_check(char *oem_id, char *oem_table_id)
 {
 	unsigned long oem_addr = 0;
 	int check_dsdt;
@@ -717,7 +717,7 @@ struct apic apic_es7000_cluster = {
 	.safe_wait_icr_idle		= native_safe_apic_wait_icr_idle,
 };

-struct apic apic_es7000 = {
+struct apic __refdata apic_es7000 = {

 	.name				= "es7000",
 	.probe				= probe_es7000,

Re: [PATCH] x86: Fix false positive section mismatch in apic.

[Ingo Molnar]

* Rakib Mullick <rakib.mullick@gmail.com> wrote:

>  Sorry guys , for being late. My system was out of order for a week.
> 
> 
>  x86: Fix false positive section mismatch warnings in the apic code
> 
> ----
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>

Ok, since the patch came from Sam i applied it as a From: Sam patch 
- and added this comment above your signoff line:

    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
    [ modified and tested it ]
    Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>

To denote your modifications on it. Hope this is fine with everyone.

	Ingo

[tip:x86/urgent] x86: Fix false positive section mismatch warnings in the apic code

[tip-bot for Sam Ravnborg]

Commit-ID:  b74d446f1f337e3fe906169a3266cb65ffa4179e
Gitweb:     http://git.kernel.org/tip/b74d446f1f337e3fe906169a3266cb65ffa4179e
Author:     Sam Ravnborg <sam@ravnborg.org>
AuthorDate: Sat, 9 May 2009 15:35:10 +0600
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 10 May 2009 09:26:54 +0200

x86: Fix false positive section mismatch warnings in the apic code

[ Impact: reduce kernel image size a bit, annotate away warnings ]

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
[ modified and tested it ]
Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
Cc: Marcin Slusarz <marcin.slusarz@gmail.com>
LKML-Reference: <b9df5fa10905090235s4bfd26a8o979f93809c9727ad@mail.gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 arch/x86/kernel/apic/es7000_32.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/apic/es7000_32.c b/arch/x86/kernel/apic/es7000_32.c
index 1c11b81..3029477 100644
--- a/arch/x86/kernel/apic/es7000_32.c
+++ b/arch/x86/kernel/apic/es7000_32.c
@@ -254,7 +254,7 @@ static int parse_unisys_oem(char *oemptr)
 }
 
 #ifdef CONFIG_ACPI
-static int find_unisys_acpi_oem_table(unsigned long *oem_addr)
+static int __init find_unisys_acpi_oem_table(unsigned long *oem_addr)
 {
 	struct acpi_table_header *header = NULL;
 	struct es7000_oem_table *table;
@@ -285,7 +285,7 @@ static int find_unisys_acpi_oem_table(unsigned long *oem_addr)
 	return 0;
 }
 
-static void unmap_unisys_acpi_oem_table(unsigned long oem_addr)
+static void __init unmap_unisys_acpi_oem_table(unsigned long oem_addr)
 {
 	if (!oem_addr)
 		return;
@@ -306,7 +306,7 @@ static int es7000_check_dsdt(void)
 static int es7000_acpi_ret;
 
 /* Hook from generic ACPI tables.c */
-static int es7000_acpi_madt_oem_check(char *oem_id, char *oem_table_id)
+static int __init es7000_acpi_madt_oem_check(char *oem_id, char *oem_table_id)
 {
 	unsigned long oem_addr = 0;
 	int check_dsdt;
@@ -717,7 +717,7 @@ struct apic apic_es7000_cluster = {
 	.safe_wait_icr_idle		= native_safe_apic_wait_icr_idle,
 };
 
-struct apic apic_es7000 = {
+struct apic __refdata apic_es7000 = {
 
 	.name				= "es7000",
 	.probe				= probe_es7000,