From: Christoph Hellwig <hch@lst.de>
To: Steven Rostedt <srostedt@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
cbe-oss-dev@ozlabs.org
Subject: Re: [Cbe-oss-dev] [PATCH, RFC] sputrace: use the generic event tracer
Date: Sun, 10 May 2009 21:07:05 +0200 [thread overview]
Message-ID: <20090510190705.GA23659@lst.de> (raw)
In-Reply-To: <1241636739.11379.29.camel@localhost.localdomain>
On Wed, May 06, 2009 at 03:05:39PM -0400, Steven Rostedt wrote:
> The worry is if this is used by modules. A constant string may not be
> around when the buffer is read.
>
> This should not be a problem because the formatting of the string is not
> around either, and we just output 'unknown type'. But I may be adding
> code when a module is unloaded to reset the ring buffer if the module
> registered any events. That's because we have other races to worry
> about.
I think having some constant string description for trace events is
pretty common and used in just above any ad-hoc tracer I've seen,
and just storing the pointers makes this a lot more efficient.
So either we try to make sure this works, or we need some big waivers
in the documentation that people need to use the slower __string
variant.
next prev parent reply other threads:[~2009-05-10 19:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090506102918.GA23278@lst.de>
2009-05-06 10:57 ` [PATCH, RFC] sputrace: use the generic event tracer Ingo Molnar
2009-05-06 11:02 ` Christoph Hellwig
2009-05-06 11:23 ` Ingo Molnar
2009-05-06 13:54 ` Steven Rostedt
2009-05-06 14:47 ` Ingo Molnar
2009-05-06 14:59 ` Steven Rostedt
2009-05-06 16:53 ` Frederic Weisbecker
2009-05-06 17:13 ` Christoph Hellwig
2009-05-06 19:05 ` Steven Rostedt
2009-05-10 19:07 ` Christoph Hellwig [this message]
2009-05-06 10:58 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090510190705.GA23659@lst.de \
--to=hch@lst.de \
--cc=cbe-oss-dev@ozlabs.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox