From: Al Viro <viro@ZenIV.linux.org.uk>
To: hooanon05@yahoo.co.jp
Cc: linux-kernel@vger.kernel.org
Subject: Re: Q. Switch open_exec() and sys_uselib() to do_open_filp()
Date: Mon, 11 May 2009 05:00:19 +0100 [thread overview]
Message-ID: <20090511040019.GI8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <31197.1242009975@jrobl>
On Mon, May 11, 2009 at 11:46:15AM +0900, hooanon05@yahoo.co.jp wrote:
> My poor English may make me misunderstood.
> Please let me make sure.
> Do you mean FMODE_EXEC was passed to struct file before this commit?
>
> Previous open_exec() used to call
> file = nameidata_to_filp(&nd, O_RDONLY|O_LARGEFILE)
> and it calls
> filp = __dentry_open(nd->path.dentry, nd->path.mnt, flags, filp,
> NULL);
> __dentry_open()
> {
> f->f_flags = flags;
> f->f_mode = ((flags+1) & O_ACCMODE) | FMODE_LSEEK |
> FMODE_PREAD | FMODE_PWRITE;
> ;;;
> }
>
> So FMODE_EXEC was not set to f_flags/f_mode, O_RDONLY|O_LARGEFILE only.
Nope. It ended up in nd->intent.open.flags due to path_lookup_open().
Then lookup_instantiate_filp() from a filesystem that might care about
intents did
nd->intent.open.file = __dentry_open(dget(dentry), mntget(nd->mnt),
nd->intent.open.flags - 1,
nd->intent.open.file,
open);
and nameidata_to_filp() ended up picking nd->intent.open.file.
So f_flags is exactly where that thing used to end up, if it ended up
anywhere at all.
next prev parent reply other threads:[~2009-05-11 4:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 0:55 Q. Switch open_exec() and sys_uselib() to do_open_filp() hooanon05
2009-05-11 1:28 ` Al Viro
2009-05-11 2:46 ` hooanon05
2009-05-11 4:00 ` Al Viro [this message]
2009-05-11 5:20 ` hooanon05
2009-05-11 6:52 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090511040019.GI8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hooanon05@yahoo.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox