From: Ingo Molnar <mingo@elte.hu>
To: Roland McGrath <roland@redhat.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
David Howells <dhowells@redhat.com>,
jmorris@namei.org, chrisw@sous-sol.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, eparis@redhat.com,
sds@tycho.nsa.gov
Subject: Re: [PATCH 1/2] CRED: Rename cred_exec_mutex to reflect that it's a guard against ptrace
Date: Mon, 11 May 2009 13:33:56 +0200 [thread overview]
Message-ID: <20090511113356.GB4748@elte.hu> (raw)
In-Reply-To: <20090510232938.A62E1FC35D@magilla.sf.frob.com>
* Roland McGrath <roland@redhat.com> wrote:
> > Hmm. Ingo's "rename ptrace_may_access => ptrace_access_check" conflicts
> > with my patch too.
>
> Andrew seemed to want a different name choice too, so that will have to be
> resolved before we worry about patch conflicts.
>
> > Andrew, Roland, I guess I should re-send
> >
> > ptrace-ptrace_attach-check-pf_kthread-exit_state-instead-of-mm.patch
> > ptrace-cleanup-check-set-of-pt_ptraced-during-attach.patch
> > ptrace-do-not-use-task_lock-for-attach.patch
> >
> > patches?
>
> I guess so too. Your series of changes is more substantial and
> potentially controversial or problematic than the various
> renamings, so I think it makes sense to settle and merge the
> renamings first.
yeah, cleanups first is generally the better strategy. Not only does
it make reverts easier, it also makes it easier to review (and
potentially fix) later patches.
Ingo
next prev parent reply other threads:[~2009-05-11 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 12:55 [PATCH 1/2] CRED: Rename cred_exec_mutex to reflect that it's a guard against ptrace David Howells
2009-05-08 12:55 ` [PATCH 2/2] CRED: Guard the setprocattr security hook " David Howells
2009-05-10 22:37 ` James Morris
2009-05-09 18:59 ` [PATCH 1/2] CRED: Rename cred_exec_mutex to reflect that it's a guard " Oleg Nesterov
2009-05-10 23:29 ` Roland McGrath
2009-05-11 11:33 ` Ingo Molnar [this message]
2009-05-10 22:37 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090511113356.GB4748@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=dhowells@redhat.com \
--cc=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox