* [PATCH] cred: #include init.h in cred.h
@ 2009-05-09 3:36 Alexey Dobriyan
2009-05-11 20:20 ` Andrew Morton
0 siblings, 1 reply; 5+ messages in thread
From: Alexey Dobriyan @ 2009-05-09 3:36 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel
linux/cred.h can't be included as first header (alphabetical order)
because it uses __init which is enough to break compilation on some
archs.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
include/linux/cred.h | 1 +
1 file changed, 1 insertion(+)
commit f3e00c7d1ece60a019b15ea4992821834fe21a31
Author: Alexey Dobriyan <adobriyan@gmail.com>
Date: Fri May 8 20:46:18 2009 +0400
cred.h: init.h
--- a/include/linux/cred.h
+++ b/include/linux/cred.h
@@ -13,6 +13,7 @@
#define _LINUX_CRED_H
#include <linux/capability.h>
+#include <linux/init.h>
#include <linux/key.h>
#include <asm/atomic.h>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cred: #include init.h in cred.h
2009-05-09 3:36 [PATCH] cred: #include init.h in cred.h Alexey Dobriyan
@ 2009-05-11 20:20 ` Andrew Morton
2009-05-11 21:16 ` Alexey Dobriyan
2009-05-11 22:32 ` James Morris
0 siblings, 2 replies; 5+ messages in thread
From: Andrew Morton @ 2009-05-11 20:20 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: linux-kernel, James Morris, David Howells
On Sat, 9 May 2009 07:36:52 +0400
Alexey Dobriyan <adobriyan@gmail.com> wrote:
> linux/cred.h can't be included as first header (alphabetical order)
> because it uses __init which is enough to break compilation on some
> archs.
>
hm, OK, not a lot of detail there though.
>
> --- a/include/linux/cred.h
> +++ b/include/linux/cred.h
> @@ -13,6 +13,7 @@
> #define _LINUX_CRED_H
>
> #include <linux/capability.h>
> +#include <linux/init.h>
> #include <linux/key.h>
> #include <asm/atomic.h>
I assume that this is needed in 2.6.30?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cred: #include init.h in cred.h
2009-05-11 20:20 ` Andrew Morton
@ 2009-05-11 21:16 ` Alexey Dobriyan
2009-05-11 22:32 ` James Morris
1 sibling, 0 replies; 5+ messages in thread
From: Alexey Dobriyan @ 2009-05-11 21:16 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, James Morris, David Howells
On Mon, May 11, 2009 at 01:20:06PM -0700, Andrew Morton wrote:
> On Sat, 9 May 2009 07:36:52 +0400
> Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > --- a/include/linux/cred.h
> > +++ b/include/linux/cred.h
> > @@ -13,6 +13,7 @@
> > #define _LINUX_CRED_H
> >
> > #include <linux/capability.h>
> > +#include <linux/init.h>
> > #include <linux/key.h>
> > #include <asm/atomic.h>
>
> I assume that this is needed in 2.6.30?
Would be nice.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cred: #include init.h in cred.h
2009-05-11 20:20 ` Andrew Morton
2009-05-11 21:16 ` Alexey Dobriyan
@ 2009-05-11 22:32 ` James Morris
2009-05-11 22:48 ` Andrew Morton
1 sibling, 1 reply; 5+ messages in thread
From: James Morris @ 2009-05-11 22:32 UTC (permalink / raw)
To: Andrew Morton; +Cc: Alexey Dobriyan, linux-kernel, David Howells
On Mon, 11 May 2009, Andrew Morton wrote:
> On Sat, 9 May 2009 07:36:52 +0400
> Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> > linux/cred.h can't be included as first header (alphabetical order)
> > because it uses __init which is enough to break compilation on some
> > archs.
> >
>
> hm, OK, not a lot of detail there though.
>
> >
> > --- a/include/linux/cred.h
> > +++ b/include/linux/cred.h
> > @@ -13,6 +13,7 @@
> > #define _LINUX_CRED_H
> >
> > #include <linux/capability.h>
> > +#include <linux/init.h>
> > #include <linux/key.h>
> > #include <asm/atomic.h>
>
> I assume that this is needed in 2.6.30?
>
I can see it's in -mm, so might as well go to Linus via there.
Acked-by: James Morris <jmorris@namei.org>
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cred: #include init.h in cred.h
2009-05-11 22:32 ` James Morris
@ 2009-05-11 22:48 ` Andrew Morton
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Morton @ 2009-05-11 22:48 UTC (permalink / raw)
To: James Morris; +Cc: adobriyan, linux-kernel, dhowells
On Tue, 12 May 2009 08:32:31 +1000 (EST)
James Morris <jmorris@namei.org> wrote:
> On Mon, 11 May 2009, Andrew Morton wrote:
>
> > On Sat, 9 May 2009 07:36:52 +0400
> > Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >
> > > linux/cred.h can't be included as first header (alphabetical order)
> > > because it uses __init which is enough to break compilation on some
> > > archs.
> > >
> >
> > hm, OK, not a lot of detail there though.
> >
> > >
> > > --- a/include/linux/cred.h
> > > +++ b/include/linux/cred.h
> > > @@ -13,6 +13,7 @@
> > > #define _LINUX_CRED_H
> > >
> > > #include <linux/capability.h>
> > > +#include <linux/init.h>
> > > #include <linux/key.h>
> > > #include <asm/atomic.h>
> >
> > I assume that this is needed in 2.6.30?
> >
>
> I can see it's in -mm, so might as well go to Linus via there.
No prob.
> Acked-by: James Morris <jmorris@namei.org>
Thanks.
This is not the sort of patch which I'd send upstream immediately.
cred.h is included by sched.h and sched.h doesn't include init.h.
That's enough uncertainty to require a few days compile-testing..
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-05-11 22:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-09 3:36 [PATCH] cred: #include init.h in cred.h Alexey Dobriyan
2009-05-11 20:20 ` Andrew Morton
2009-05-11 21:16 ` Alexey Dobriyan
2009-05-11 22:32 ` James Morris
2009-05-11 22:48 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox