From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759483AbZEKVfx (ORCPT ); Mon, 11 May 2009 17:35:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754723AbZEKVfo (ORCPT ); Mon, 11 May 2009 17:35:44 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:50605 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754086AbZEKVfo (ORCPT ); Mon, 11 May 2009 17:35:44 -0400 Date: Mon, 11 May 2009 14:29:36 -0700 From: Andrew Morton To: David Rientjes Cc: gregkh@suse.de, npiggin@suse.de, mel@csn.ul.ie, a.p.ziljstra@chello.nl, cl@linux-foundation.org, dave@linux.vnet.ibm.com, san@android.com, arve@android.com, linux-kernel@vger.kernel.org Subject: Re: [patch 08/11 -mmotm] oom: invoke oom killer for __GFP_NOFAIL Message-Id: <20090511142936.dd68005b.akpm@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 10 May 2009 15:07:21 -0700 (PDT) David Rientjes wrote: > The oom killer must be invoked regardless of the order if the allocation > is __GFP_NOFAIL, otherwise it will loop forever when reclaim fails to > free some memory. We should discourage callers from using __GFP_NOFAIL at all. We should electrocute callers for using __GFP_NOFAIL on large allocations. How's about WARN_ON_ONCE(order > PAGE_ALLOC_COSTLY_ORDER && (gfp_mask & __GFP_NOFAIL)); or, preferably: WARN_ON_ONCE(order > 0 && (gfp_mask & __GFP_NOFAIL)); ?