From: Ingo Molnar <mingo@elte.hu>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-tip-commits@vger.kernel.org"
<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/xen] x86: use flush_tlb_others to implement flush_tlb_all, fix
Date: Mon, 11 May 2009 17:42:02 +0200 [thread overview]
Message-ID: <20090511154202.GA31655@elte.hu> (raw)
In-Reply-To: <1242056394.29990.94.camel@zakaz.uk.xensource.com>
* Ian Campbell <Ian.Campbell@eu.citrix.com> wrote:
> in any case I would guess that the fix is:
>
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -87,6 +87,7 @@
> #include <asm/cacheflush.h>
> #include <asm/processor.h>
> #include <asm/bugs.h>
> +#include <asm/tlbflush.h>
>
> #include <asm/system.h>
> #include <asm/vsyscall.h>
Guessing is not enough - please review the prototype position. Is it
available on all configs? It is not ...
But even the proper fix runs into that smp_processor_id() bug i just
posted.
Ingo
next prev parent reply other threads:[~2009-05-11 15:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 20:24 [GIT PULL] Xen core updates Jeremy Fitzhardinge
2009-05-07 20:24 ` [PATCH 1/8] xen/x86-64: fix breakpoints and hardware watchpoints Jeremy Fitzhardinge
2009-05-07 20:24 ` [PATCH 2/8] xen/x86-64: clean up warnings about IST-using traps Jeremy Fitzhardinge
2009-05-07 20:24 ` [PATCH 3/8] xen: cache cr0 value to avoid trap'n'emulate for read_cr0 Jeremy Fitzhardinge
2009-05-07 20:24 ` [PATCH 4/8] xen: deal with NMI's use of IST too Jeremy Fitzhardinge
2009-05-07 20:24 ` [PATCH 5/8] xen/i386: make sure initial VGA/ISA mappings are not overridden Jeremy Fitzhardinge
2009-05-08 10:57 ` Ingo Molnar
2009-05-08 15:08 ` Jeremy Fitzhardinge
2009-05-07 20:25 ` [PATCH 6/8] x86: use flush_tlb_others to implement flush_tlb_all Jeremy Fitzhardinge
2009-05-08 15:24 ` Ian Campbell
2009-05-08 15:49 ` Jeremy Fitzhardinge
2009-05-08 15:52 ` Ian Campbell
2009-05-11 13:09 ` [tip:x86/xen] x86: use flush_tlb_others to implement flush_tlb_all, fix tip-bot for Ian Campbell
2009-05-11 13:12 ` Ingo Molnar
2009-05-11 15:00 ` Ian Campbell
2009-05-11 15:11 ` Ingo Molnar
2009-05-11 15:39 ` Ian Campbell
2009-05-11 15:42 ` Ingo Molnar [this message]
2009-05-11 15:59 ` Ian Campbell
2009-05-11 15:40 ` Ingo Molnar
2009-05-11 15:06 ` tip-bot for Ian Campbell
2009-05-07 20:25 ` [PATCH 7/8] xen/i386: reserve Xen pagetables Jeremy Fitzhardinge
2009-05-07 20:25 ` [PATCH 8/8] xen: reserve Xen start_info rather than e820 reserving Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090511154202.GA31655@elte.hu \
--to=mingo@elte.hu \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Jeremy.Fitzhardinge@citrix.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox