Re: [PATCH 1/5] Split wait_noreap_copyout()

Vitaly Mayatskikh
2009-05-11T11:20:26Z

At Mon, 11 May 2009 12:20:50 +0200, Ingo Molnar wrote:

> > -static int wait_noreap_copyout(struct wait_opts *wo, struct task_struct *p,
> > - pid_t pid, uid_t uid, int why, int status)
> > +static int wait_copyout(struct wait_opts *wo, struct task_struct *p,
> > + pid_t pid, uid_t uid, int why, int status, int signal)
>
> Nice cleanups. Would be nice to fix the naming here too while at it.
>
> Right now it's two verbs and a straightforward reading of it suggest
> that we 'wait for some copyout to occur', which is nonsensical and
> confusing.
>
> So please put the main action as the first verb (this is an internal
> symbol so no subsystem differentiator is needed). Something like:
>
> copy_wait_opts_to_user()
>
> ... and it becomes a whole lot easier to read. This matches the
> copy*to_user idioms we have elsewhere so it nicely wibes with the
> sound of those.

Sure, will repost with naming fixes soon.
--
wbr, Vitaly