From: Frans Pop <elendil@planet.nl>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
len.brown@intel.com, mingo@elte.hu, johnstul@us.ibm.com
Subject: Re: [PATCH] ACPI: do not mark TSC unstable for invalid C-states
Date: Mon, 11 May 2009 17:03:07 +0200 [thread overview]
Message-ID: <200905111703.08645.elendil@planet.nl> (raw)
In-Reply-To: <alpine.LFD.2.00.0905111614570.3561@localhost.localdomain>
On Monday 11 May 2009, Thomas Gleixner wrote:
> commit a71e4917dc0ebbcb5a0ecb7ca3486643c1c9a6e2 (ACPI: idle:
> mark_tsc_unstable() at init-time, not run-time) marks TSC unstable
> even on non affected systems.
>
> The reason is that the state enumeration does not check the cx->valid
> flag before calling tsc_halts_in_c(), so it marks TSC unstable for any
> enumerated albeit invalid C state which is known to turn off TSC.
>
> Check cx->valid before checking whether the TSC might become unstable.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Frans Pop <elendil@planet.nl>
Thanks Thomas.
next prev parent reply other threads:[~2009-05-11 15:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 4:14 regression in TSC unstable? Steven Rostedt
2009-05-08 5:21 ` Len Brown
2009-05-08 12:07 ` Ingo Molnar
2009-05-11 0:26 ` Regression in TSC unstable -- confirmed Frans Pop
2009-05-11 14:22 ` [PATCH] ACPI: do not mark TSC unstable for invalid C-states Thomas Gleixner
2009-05-11 15:00 ` Steven Rostedt
2009-05-11 15:03 ` Frans Pop [this message]
2009-05-11 16:43 ` Janne Kulmala
2009-05-14 19:46 ` Len Brown
2009-05-14 20:09 ` Len Brown
2009-05-14 20:19 ` Thomas Gleixner
2009-05-14 21:55 ` [PATCH] ACPI: idle: fix init-time TSC check regression Len Brown
2009-05-14 22:27 ` Thomas Gleixner
2009-05-15 3:36 ` Len Brown
2009-05-14 22:31 ` Frans Pop
2009-05-15 5:40 ` [PATCH] ACPI: Idle C-states disabled by max_cstate should not disable the TSC Len Brown
2009-05-15 6:18 ` [PATCH] ACPI: idle: rename lapic timer workaround routines Len Brown
2009-05-15 8:28 ` Thomas Gleixner
2009-05-15 8:27 ` [PATCH] ACPI: Idle C-states disabled by max_cstate should not disable the TSC Thomas Gleixner
2009-05-15 10:57 ` [PATCH] ACPI: idle: fix init-time TSC check regression Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905111703.08645.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=johnstul@us.ibm.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox