From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759511AbZEKU5X (ORCPT ); Mon, 11 May 2009 16:57:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759288AbZEKU5A (ORCPT ); Mon, 11 May 2009 16:57:00 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50789 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758564AbZEKU47 (ORCPT ); Mon, 11 May 2009 16:56:59 -0400 Date: Mon, 11 May 2009 13:51:17 -0700 From: Greg KH To: Kay Sievers Cc: Stephen Rothwell , Greg KH , linux-kernel@vger.kernel.org, Jan Blunck Subject: Re: [patch 01/13] Driver Core: add nodename callbacks Message-ID: <20090511205117.GA27815@suse.de> References: <20090509142601.874865281@blue.kroah.org> <20090509143631.276407654@blue.kroah.org> <20090510225246.0a77b557.sfr@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 10, 2009 at 03:19:46PM +0200, Kay Sievers wrote: > On Sun, May 10, 2009 at 14:52, Stephen Rothwell wrote: > > >> +++ b/include/linux/device.h > >>  struct device { > >>       struct device           *parent; > >> +     char *(*nodename)(struct device *dev); > > > > Just wondering what this callback is for.  I didn't look really hard, but > > couldn't find it used anywhere. > > You are right, that seems like a left-over which did not get used, and > should be removed from the patch. I've now removed it, thanks Stephen for finding this. greg k-h