public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Cihula, Joseph" <joseph.cihula@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"arjan@linux.intel.com" <arjan@linux.intel.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"andi@firstfloor.org" <andi@firstfloor.org>,
	"chrisw@sous-sol.org" <chrisw@sous-sol.org>,
	"jmorris@namei.org" <jmorris@namei.org>,
	"jbeulich@novell.com" <jbeulich@novell.com>,
	"peterm@redhat.com" <peterm@redhat.com>,
	"Wei, Gang" <gang.wei@intel.com>,
	"Wang, Shane" <shane.wang@intel.com>
Subject: Re: [RFC v3][PATCH 2/2] intel_txt: Intel(R) TXT and tboot kernel support
Date: Tue, 12 May 2009 11:55:28 +0200	[thread overview]
Message-ID: <20090512095528.GG19296@one.firstfloor.org> (raw)
In-Reply-To: <20090512094544.GE32292@elte.hu>

> > > > +   ((void(*)(void))(long)tboot_shared->shutdown_entry)();
> 
> be better? Or is shutdown_entry always mapped into [0..2GB) on 

0..4GB and this code runs in a identity mapping.

> 64-bit? Even then, not sign-extending RIP addresses is wrong and 
> invites bugs/restrictions.

You never have to sign extend when going from 32bit to 64bit
on x86-64.

-andi

-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2009-05-12  9:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-08  4:49 [RFC v3][PATCH 2/2] intel_txt: Intel(R) TXT and tboot kernel support Joseph Cihula
2009-05-08  6:53 ` Andrew Morton
2009-05-29  1:02   ` Cihula, Joseph
2009-05-08  9:57 ` Ingo Molnar
2009-05-12  5:26   ` Cihula, Joseph
2009-05-12  9:45     ` Ingo Molnar
2009-05-12  9:55       ` Andi Kleen [this message]
2009-05-12 21:01 ` Theodore Tso
2009-05-14 15:52   ` Heinz Diehl
2009-05-15  0:17   ` James Morris
2009-05-15  1:45     ` Cihula, Joseph
2009-05-15  1:51       ` Joe Perches
2009-05-15  2:49         ` Cihula, Joseph
2009-05-28  1:12           ` James Morris
2009-05-15 12:07       ` Theodore Tso
2009-05-15 12:26         ` Theodore Tso
2009-05-24 19:42         ` Pavel Machek
2009-05-24 19:42       ` Pavel Machek
     [not found]         ` <E1M8kJQ-0000W3-TE@fencepost.gnu.org>
2009-05-26  2:31           ` Theodore Tso
     [not found]             ` <E1M9Mig-0003Q4-S1@fencepost.gnu.org>
2009-05-29  9:47               ` Pavel Machek
2009-05-19 20:30     ` Pavel Machek
2009-05-22 16:59       ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090512095528.GG19296@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=arjan@linux.intel.com \
    --cc=chrisw@sous-sol.org \
    --cc=gang.wei@intel.com \
    --cc=hpa@zytor.com \
    --cc=jbeulich@novell.com \
    --cc=jmorris@namei.org \
    --cc=joseph.cihula@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterm@redhat.com \
    --cc=shane.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox