From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760325AbZELLN4 (ORCPT ); Tue, 12 May 2009 07:13:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755369AbZELLNr (ORCPT ); Tue, 12 May 2009 07:13:47 -0400 Received: from moutng.kundenserver.de ([212.227.126.188]:63567 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbZELLNr convert rfc822-to-8bit (ORCPT ); Tue, 12 May 2009 07:13:47 -0400 From: Arnd Bergmann To: monstr@monstr.eu Subject: Re: [PATCH 11/12] microblaze: dont include asm/mmu.h in hw_exception_handler Date: Tue, 12 May 2009 13:13:35 +0200 User-Agent: KMail/1.9.9 Cc: linux-kernel@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au References: <20090511232019.927138561@arndb.de> <20090511232345.746701938@arndb.de>> <4A093D6E.7060309@monstr.eu> In-Reply-To: <4A093D6E.7060309@monstr.eu> X-Face: I@=L^?./?$U,EK.)V[4*>`zSqm0>65YtkOe>TFD'!aw?7OVv#~5xd\s,[~w]-J!)|%=]>=?utf-8?q?+=0A=09=7EohchhkRGW=3F=7C6=5FqTmkd=5Ft=3FLZC=23Q-=60=2E=60Y=2Ea=5E?= =?utf-8?q?3zb?=) =?utf-8?q?+U-JVN=5DWT=25cw=23=5BYo0=267C=26bL12wWGlZi=0A=09=7EJ=3B=5Cwg?= =?utf-8?q?=3B3zRnz?=,J"CT_)=\H'1/{?SR7GDu?WIopm.HaBG=QYj"NZD_[zrM\Gip^U MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <200905121313.35501.arnd@arndb.de> X-Provags-ID: V01U2FsdGVkX1/uKNAk5waXB2ajgLXr+1MJwuc4cRbymyC/JUG JfvjheiIPplRokUMCY8a6AuPb1X9z0KJMunc7+FJEFSQOcK1nh JkfW8lqIqqvMSayM92jDw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 12 May 2009, Michal Simek wrote: > 1. Please do not attach your patches - use in-line patches - > it is easier for me and for others to review it. Something went wrong (again...) with my patches this time, so they got rejected by vger. They are not attached however AFAICT, but are inline with the "Content-Disposition: inline;" header, which is generated by "quilt mail". Which tool do you use that does not work with this correctly? > - but on the other hand I need mmu.h for mmu patches - because of MICROBLAZE_TLB_SIZE >   - if you think that mmu.h shouldn't be included we have to >   move this definition to another file >   - you can look at my next branch to see mmu context Almost all architectures disallow using mmu.h in assembly, only powerpc and sh have an '#ifndef __ASSEMBLY__' in there. I did the change to allow using my asm-generic/mmu.h for microblaze-nommu. When your MMU code gets merged, this is no longer required though, because you cannot simply fall back on the asm-generic version anyway. Arnd <><