From: Ingo Molnar <mingo@elte.hu>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>,
mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
a.p.zijlstra@chello.nl, schwidefsky@de.ibm.com,
balajirrao@gmail.com, dhaval@linux.vnet.ibm.com,
bharata@linux.vnet.ibm.com, tglx@linutronix.de,
kamezawa.hiroyu@jp.fujitsu.com,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] sched: cpuacct: Use bigger percpu counter batch values for stats counters
Date: Tue, 12 May 2009 15:42:54 +0200 [thread overview]
Message-ID: <20090512134254.GA13423@elte.hu> (raw)
In-Reply-To: <2f11576a0905120640qcecc90ase686095b0d9ef014@mail.gmail.com>
* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> 2009/5/12 Ingo Molnar <mingo@elte.hu>:
> >
> > * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> >
> >> > or rather, to make cpuacct_batch have a sane value on UP too.
> >> > (1? 0?)
> >>
> >> umm..
> >>
> >> I've reviewed my patch again.
> >> but sched_init() already has multiple #ifdef SMP. [...]
> >
> > Patches are welcome to remove more of them.
> >
> >> [...] Thus I don't think cosmetic changing improve readability
> >> largely.
> >
> > an avoidable #ifdef should aways be avoided.
>
> ok. I'll fix it tommorow.
With the caveat that you should do it only if i'm right and if it
results in better code in general.
Ingo
next prev parent reply other threads:[~2009-05-12 13:43 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 9:59 [PATCH v3] cpuacct: VIRT_CPU_ACCOUNTING don't prevent percpu cputime count KOSAKI Motohiro
2009-05-07 10:50 ` Ingo Molnar
2009-05-09 9:26 ` KOSAKI Motohiro
2009-05-09 9:38 ` Peter Zijlstra
2009-05-09 9:52 ` KOSAKI Motohiro
2009-05-09 10:14 ` KOSAKI Motohiro
2009-05-11 12:33 ` [tip:sched/core] sched: cpuacct: Use bigger percpu counter batch values for stats counters tip-bot for KOSAKI Motohiro
2009-05-11 12:36 ` tip-bot for KOSAKI Motohiro
2009-05-11 15:07 ` Ingo Molnar
2009-05-12 10:01 ` KOSAKI Motohiro
2009-05-12 10:02 ` Peter Zijlstra
2009-05-12 10:06 ` KOSAKI Motohiro
2009-05-12 10:22 ` KOSAKI Motohiro
2009-05-12 10:27 ` Ingo Molnar
2009-05-12 10:42 ` KOSAKI Motohiro
2009-05-12 10:10 ` Balbir Singh
2009-05-12 10:13 ` KOSAKI Motohiro
2009-05-12 10:24 ` Balbir Singh
2009-05-12 10:29 ` Ingo Molnar
2009-05-12 10:44 ` KOSAKI Motohiro
2009-05-12 13:28 ` Ingo Molnar
2009-05-12 13:40 ` KOSAKI Motohiro
2009-05-12 13:42 ` Ingo Molnar [this message]
2009-07-16 8:10 ` Bharata B Rao
2009-07-16 8:39 ` Anton Blanchard
2009-08-20 5:10 ` Anton Blanchard
2009-08-20 5:16 ` KAMEZAWA Hiroyuki
2009-08-20 5:26 ` Balbir Singh
2009-08-20 5:52 ` Peter Zijlstra
2009-08-20 6:05 ` Anton Blanchard
2009-08-20 6:10 ` KAMEZAWA Hiroyuki
2009-08-20 6:24 ` Anton Blanchard
2009-08-20 8:41 ` [PATCH] better align percpu counter (Was " KAMEZAWA Hiroyuki
2009-08-20 10:04 ` Ingo Molnar
2009-08-21 2:20 ` KAMEZAWA Hiroyuki
2009-08-21 11:29 ` Ingo Molnar
2009-08-21 3:56 ` KAMEZAWA Hiroyuki
2009-08-20 11:46 ` Balbir Singh
2009-08-21 6:21 ` KAMEZAWA Hiroyuki
2010-01-18 4:41 ` [PATCH] " Anton Blanchard
2010-01-18 4:55 ` KOSAKI Motohiro
2010-01-18 7:51 ` Peter Zijlstra
2010-01-18 8:21 ` Anton Blanchard
2010-01-18 8:34 ` Peter Zijlstra
2010-01-18 8:35 ` Balbir Singh
2010-01-18 9:42 ` Martin Schwidefsky
2010-01-18 9:55 ` Anton Blanchard
2010-01-18 11:00 ` Balbir Singh
2010-01-21 15:25 ` Balbir Singh
2010-01-21 15:36 ` Peter Zijlstra
2010-01-25 23:14 ` Andrew Morton
2010-01-25 23:44 ` KOSAKI Motohiro
2010-01-26 6:17 ` Balbir Singh
2010-01-26 6:35 ` Andrew Morton
2010-01-26 8:07 ` Anton Blanchard
2010-01-27 13:15 ` [tip:sched/urgent] " tip-bot for Anton Blanchard
2010-01-27 13:34 ` Balbir Singh
2010-01-27 21:22 ` Andrew Morton
2010-01-27 21:43 ` Peter Zijlstra
2010-01-28 12:48 ` [PATCH 1/2] percpu_counter: Make __percpu_counter_add an inline function on UP Anton Blanchard
2010-01-28 12:52 ` [PATCH 2/2] sched: cpuacct: Use bigger percpu counter batch values for stats counters Anton Blanchard
2010-01-28 5:21 ` [tip:sched/urgent] " Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512134254.GA13423@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=balajirrao@gmail.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox