From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755512AbZELOvn (ORCPT ); Tue, 12 May 2009 10:51:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752951AbZELOvc (ORCPT ); Tue, 12 May 2009 10:51:32 -0400 Received: from mail-ew0-f176.google.com ([209.85.219.176]:43172 "EHLO mail-ew0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752581AbZELOvb (ORCPT ); Tue, 12 May 2009 10:51:31 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; b=IJ1KLt+yUb4phSq1GpQ/0K60/vg9v5YGR/4tTLm2aR1IjGqCBtrf97jz5zqPvbcuAC j2njoOZ8RETeDlcCM94V2KOMxuevFQ6ZltWDgTnoQfT0pu2o5zb0+77Jsk77DmqePlVg e7EG5BJMjLiktbHxmqyPDmwmuRLnodgADyttk= Date: Tue, 12 May 2009 18:51:28 +0400 From: Cyrill Gorcunov To: Ingo Molnar Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, yinghai@kernel.org, tglx@linutronix.de, eswierk@aristanetworks.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:irq/numa] x86: read apic ID in the !acpi_lapic case Message-ID: <20090512145128.GA10220@lenovo> References: <49FC85A9.2070702@kernel.org> <20090512112205.GA12108@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20090512112205.GA12108@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Ingo Molnar - Tue, May 12, 2009 at 01:22:05PM +0200] | | this build bug is still unfixed: | | drivers/pci/hotplug/ibmphp_core.c:165: error: expected identifier before ‘&’ token | drivers/pci/hotplug/ibmphp_core.c:166: error: too few arguments to function ‘IO_APIC_get_PCI_irq_vector’ | | Ingo | Grrr... this line looks really suspicious inideed for (i = 0; i < 4; i++) (*cur_slot)->irq[i] = IO_APIC_get_PCI_irq_vector((int) (*cur_slot)->bus, ---> (int) (*cur_slot)->device, i. &ioapic, &ioapic_pin, &triggering, &polarity); but it's _not_ 'cause of this commit, since we didn't even touch this file :) The point symbol should be changed to comma. Just a misprint I believe. Appened patch should do the trick. -- Cyrill --- From: Cyrill Gorcunov Subject: [PATCH] pci: ibmphp_core.c - fix misprint in ibmphp_init_devno Signed-off-by: Cyrill Gorcunov CC: Yinghai Lu --- drivers/pci/hotplug/ibmphp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.git/drivers/pci/hotplug/ibmphp_core.c ===================================================================== --- linux-2.6.git.orig/drivers/pci/hotplug/ibmphp_core.c +++ linux-2.6.git/drivers/pci/hotplug/ibmphp_core.c @@ -161,7 +161,7 @@ int ibmphp_init_devno(struct slot **cur_ (*cur_slot)->device = PCI_SLOT(rtable->slots[loop].devfn); for (i = 0; i < 4; i++) (*cur_slot)->irq[i] = IO_APIC_get_PCI_irq_vector((int) (*cur_slot)->bus, - (int) (*cur_slot)->device, i. + (int) (*cur_slot)->device, i, &ioapic, &ioapic_pin, &triggering, &polarity);