From: Arnd Bergmann <ARNDB@de.ibm.com>
To: jblunck@suse.de
Cc: Linux-Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Jeremy Kerr <jk@ozlabs.org>
Subject: Re: [patch 2/2] spufs: remove double check for non-negative dentry
Date: Tue, 12 May 2009 16:15:25 +0200 [thread overview]
Message-ID: <200905121615.25936.ARNDB@de.ibm.com> (raw)
In-Reply-To: <20090505214434.097370118@suse.de>
On Tuesday 05 May 2009, jblunck@suse.de wrote:
> This patch removes an unnecessary double check if the dentry returned by
> lookup_create() is actually non-negative. Since lookup_create() itself returns
> an error in this case just remove the check.
>
> Signed-off-by: Jan Blunck <jblunck@suse.de>
Looks good, I'll push this one on, unless Jeremy has objections.
Thanks,
Arnd <><
> --- a/arch/powerpc/platforms/cell/spufs/inode.c
> +++ b/arch/powerpc/platforms/cell/spufs/inode.c
> @@ -625,10 +625,6 @@ long spufs_create(struct nameidata *nd,
> if (IS_ERR(dentry))
> goto out_dir;
>
> - ret = -EEXIST;
> - if (dentry->d_inode)
> - goto out_dput;
> -
> mode &= ~current->fs->umask;
>
> if (flags & SPU_CREATE_GANG)
>
prev parent reply other threads:[~2009-05-12 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 21:32 [patch 0/2] spufs: Minor cleanups jblunck
2009-05-05 21:32 ` [patch 1/2] spufs: make dentry reference count and locking symmetric jblunck
2009-05-12 14:03 ` Arnd Bergmann
2009-05-05 21:32 ` [patch 2/2] spufs: remove double check for non-negative dentry jblunck
2009-05-12 14:15 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905121615.25936.ARNDB@de.ibm.com \
--to=arndb@de.ibm.com \
--cc=jblunck@suse.de \
--cc=jk@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox