From: Mathieu Desnoyers <compudj@krystal.dyndns.org>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH urcu] Use pthread_equal() for pthread_t's equality test
Date: Tue, 12 May 2009 14:54:16 -0400 [thread overview]
Message-ID: <20090512185415.GA22500@Krystal> (raw)
In-Reply-To: <1233911220-27912-1-git-send-email-bert.wesarg@googlemail.com>
* Bert Wesarg (bert.wesarg@googlemail.com) wrote:
> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
> ---
> urcu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Hi Bert,
I have to ask all userspace RCU committers for permission to move the
code to LGPL. IBM already gave their approval. Is it OK with you wrt to
the patch you posted here ?
Mathieu
> diff --git a/urcu.c b/urcu.c
> index d0d6138..e401d8d 100644
> --- a/urcu.c
> +++ b/urcu.c
> @@ -185,7 +185,7 @@ void urcu_remove_reader(pthread_t id)
>
> assert(reader_data != NULL);
> for (index = reader_data; index < reader_data + num_readers; index++) {
> - if (index->tid == id) {
> + if (pthread_equal(index->tid, id)) {
> memcpy(index, &reader_data[num_readers - 1],
> sizeof(struct reader_data));
> reader_data[num_readers - 1].tid = 0;
> --
> 1.6.1.rc4
>
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2009-05-12 18:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 9:07 [PATCH urcu] Use pthread_equal() for pthread_t's equality test Bert Wesarg
2009-05-12 18:54 ` Mathieu Desnoyers [this message]
2009-05-13 5:08 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512185415.GA22500@Krystal \
--to=compudj@krystal.dyndns.org \
--cc=bert.wesarg@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox