From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757532AbZEMAaA (ORCPT ); Tue, 12 May 2009 20:30:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752445AbZEMA3o (ORCPT ); Tue, 12 May 2009 20:29:44 -0400 Received: from plexity.net ([206.123.115.38]:40876 "EHLO plexity.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939AbZEMA3o (ORCPT ); Tue, 12 May 2009 20:29:44 -0400 Date: Wed, 13 May 2009 00:28:50 +0000 From: Deepak Saxena To: Alan Cox Cc: Linus Torvalds , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] 8250: Don't restore NS16550 mode when console suspend is disabled Message-ID: <20090513002850.GA28422@plexity.net> Reply-To: dsaxena@plexity.net References: <20090512210015.GA25540@plexity.net> <20090513011842.22d9cd6c@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090513011842.22d9cd6c@lxorguk.ukuu.org.uk> Organization: Plexity, LLC User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On May 13 2009, at 01:18, Alan Cox was caught saying: > > Hmm. I already applied this, but then after looking closer, I undid that. > > Why? It looks buggy: > > I'm a bit suprised that as tty and serial maintainer this is the first > time I see the patch. I looked in MAINTAINERS and 8250 is listed as unmaintained. :) > > Isn't that second test wrong? Should it not be > > > > if ((up->capabilities & UART_NATSEMI) && > > (console_suspend_enabled || !uart_console(&up->port)) { > > > > instead? > > The patch seems totally bogus anyway. If the console was in a high speed > mode it should be resumed in a high speed mode. What are the actual > details here. > > Surely if my console is at 230Kbits/sec then resuming it at a totally > different speed is going to break things for people even if it happens to > help XO debug ? The console is not in high speed mode when we suspend. The original commit (b5b82df6) just assumes that if it is a NATSEMI device, we should set it to high speed mode at resume w/o checking if that was the mode we were in when we suspended. ~Deepak -- In the end, they will not say, "those were dark times," they will ask "why were their poets silent?" - Bertold Brecht