From: Jens Axboe <jens.axboe@oracle.com>
To: Tejun Heo <tj@kernel.org>
Cc: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>,
Boaz Harrosh <bharrosh@panasas.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-kernel@vger.kernel.org, benh@kernel.crashing.org
Subject: Re: [PATCH] swim3: use blk_end_request instead of blk_update_request
Date: Wed, 13 May 2009 07:59:14 +0200 [thread overview]
Message-ID: <20090513055913.GZ4140@kernel.dk> (raw)
In-Reply-To: <4A0A6003.8060800@kernel.org>
On Wed, May 13 2009, Tejun Heo wrote:
> Jens Axboe wrote:
> >>> Yeah, conversion was easy that way. I think it's sane to have
> >>> blk_update_request() exported as long as request internal tinkering is
> >>> kept in block layer proper.
> >> blk_update_request() is needed for request-based dm to keep the request
> >> completion ordering in bottom-up, although request-based dm is not
> >> in upstream yet.
> >>
> >> Jens, please keep blk_update_request() exported.
> >
> > I did, I applied the swim3 patches yesterday as well.
>
> I don't think the patch is correct. If it calls
> blk_end_request_all(), it should also clear the current request which
> the patch doesn't. Also, given that the driver doesn't support
> partially failing the request, I think it's correct to fail
> segment-by-segment to avoid merged request failure affects unrelated
> bios.
>
> Thanks.
OK, I'll back them out for now.
--
Jens Axboe
next prev parent reply other threads:[~2009-05-13 5:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 11:29 [PATCH 0/2] swim3: use blk_end_request_all() FUJITA Tomonori
2009-05-12 11:29 ` [PATCH] swim3: use blk_end_request_all when we hit the maximum retry count FUJITA Tomonori
2009-05-12 11:29 ` [PATCH] swim3: use blk_end_request instead of blk_update_request FUJITA Tomonori
2009-05-12 14:45 ` Boaz Harrosh
2009-05-12 15:06 ` FUJITA Tomonori
2009-05-12 15:27 ` Tejun Heo
2009-05-13 0:50 ` Kiyoshi Ueda
2009-05-13 5:49 ` Jens Axboe
2009-05-13 5:52 ` Tejun Heo
2009-05-13 5:59 ` Jens Axboe [this message]
2009-05-12 15:25 ` [PATCH 0/2] swim3: use blk_end_request_all() Tejun Heo
2009-05-12 15:31 ` FUJITA Tomonori
2009-05-12 15:36 ` Tejun Heo
2009-05-12 15:51 ` FUJITA Tomonori
2009-05-12 22:58 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090513055913.GZ4140@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=benh@kernel.crashing.org \
--cc=bharrosh@panasas.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=k-ueda@ct.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox