From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1760075AbZEMPVS@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760075AbZEMPVS (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 May 2009 11:21:18 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757535AbZEMPVA
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 13 May 2009 11:21:00 -0400
Received: from mx2.redhat.com ([66.187.237.31]:42111 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756887AbZEMPU7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 May 2009 11:20:59 -0400
Date: Wed, 13 May 2009 18:20:43 +0300
From: Gleb Natapov <gleb@redhat.com>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Przemysssaw Paweeeczyk <przemyslaw@pawelczyk.it>,
       Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
       lkml <linux-kernel@vger.kernel.org>,
       systemtap <systemtap@sources.redhat.com>, kvm <kvm@vger.kernel.org>,
       Jim Keniston <jkenisto@us.ibm.com>, "H. Peter Anvin" <hpa@zytor.com>,
       Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
       Frederic Weisbecker <fweisbec@gmail.com>,
       Andi Kleen <ak@linux.intel.com>,
       Vegard Nossum <vegard.nossum@gmail.com>, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH -tip v5 1/7] x86: instruction decorder API
Message-ID: <20090513152043.GX18554@redhat.com>
References: <20090509004829.5505.38720.stgit@localhost.localdomain> <20090509004841.5505.48140.stgit@localhost.localdomain> <20090513082310.GQ18554@redhat.com> <40e92d5b0905130235p2c60bd56y4f001247e11d6302@mail.gmail.com> <20090513094326.GA22281@redhat.com> <4A0ADACB.8030205@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A0ADACB.8030205@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 13, 2009 at 10:35:55AM -0400, Masami Hiramatsu wrote:
> Gleb Natapov wrote:
> > On Wed, May 13, 2009 at 11:35:16AM +0200, Przemysssaw Paweeeczyk wrote:
> >> On Wed, May 13, 2009 at 10:23, Gleb Natapov <gleb@redhat.com> wrote:
> >>> On Fri, May 08, 2009 at 08:48:42PM -0400, Masami Hiramatsu wrote:
> >>>> +++ b/arch/x86/scripts/gen-insn-attr-x86.awk
> >>>> @@ -0,0 +1,314 @@
> >>>> +#!/bin/awk -f
> >>> On some distributions (debian) it is /usr/bin/awk.
> >> True, but on most of them (all?) there is also an appropriate link in /bin.
> > Nope, not on debian testing. Although I assume if kernel compilation
> > will start to fail it will appear :)
> > 
> >> If shebang could have more that one argument, then '/usr/bin/env awk
> >> -f' would be the best solution I think.
> 
> Ah, I see.
> Actually, it will be executed from Makefile with 'awk -f'.
> 
> > --- a/arch/x86/lib/Makefile
> > +++ b/arch/x86/lib/Makefile
> > @@ -2,12 +2,21 @@
> >  # Makefile for x86 specific library files.
> >  #
> >  
> > +quiet_cmd_inat_tables = GEN     $@
> > +      cmd_inat_tables = awk -f $(srctree)/arch/x86/scripts/gen-insn-attr-x86.awk $(srctree)/arch/x86/lib/x86-opcode-map.txt > $@
> > +
> 
> So, if awk is on the PATH, it will pass.
Ah, that is good enough I thing. I tried to run scrip manually.

> Maybe, I need to add 'HOSTAWK = awk' line in Makefile.
> 

--
			Gleb.