From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761610AbZEMUsB (ORCPT ); Wed, 13 May 2009 16:48:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761540AbZEMUrY (ORCPT ); Wed, 13 May 2009 16:47:24 -0400 Received: from mail-bw0-f222.google.com ([209.85.218.222]:40473 "EHLO mail-bw0-f222.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761474AbZEMUrW (ORCPT ); Wed, 13 May 2009 16:47:22 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:date:message-id:in-reply-to:references:subject; b=mtMobBRKc8RKNYXPi4AbogY5ENJAoxLEu4Hgwi1yqD2iutS6EDCjli+R/Wqzq9Oizo zGzcSHcHgW8sG2qjqZL25CQ5TnePxMFDLcfmNy77znW/DfgtyYm5n1fDGC+WWb8mS1nz ZbeSp5nI6IJAlzeBkflVSqOjjT51rsc/9jaXs= From: Bartlomiej Zolnierkiewicz To: linux-ide@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org Date: Wed, 13 May 2009 22:51:53 +0200 Message-Id: <20090513205153.28638.52533.sendpatchset@localhost.localdomain> In-Reply-To: <20090513205139.28638.87226.sendpatchset@localhost.localdomain> References: <20090513205139.28638.87226.sendpatchset@localhost.localdomain> Subject: [PATCH 2/7] ide: BUG() on unknown flags in ide_disk_special() Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/ide/ide-io.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) Index: b/drivers/ide/ide-io.c =================================================================== --- a/drivers/ide/ide-io.c +++ b/drivers/ide/ide-io.c @@ -201,12 +201,8 @@ static ide_startstop_t ide_disk_special( } else if (s->b.set_multmode) { s->b.set_multmode = 0; ide_tf_set_setmult_cmd(drive, &cmd.tf); - } else if (s->all) { - int special = s->all; - s->all = 0; - printk(KERN_ERR "%s: bad special flag: 0x%02x\n", drive->name, special); - return ide_stopped; - } + } else + BUG(); cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE; cmd.valid.in.tf = IDE_VALID_IN_TF | IDE_VALID_DEVICE;