Re: [PATCH 06/10] x86/PCI: Enable scanning of all pci functions

Jeremy Fitzhardinge
2009-05-13T20:33:17Z

Jesse Barnes wrote:
>> I'd probably go the weak function path if I were to do either of
>> those, but do you think it would be significantly better?
>>
>
> Well it would avoid the #undef, which is the gross part. But since
> it's just a boolean, you could also do
>
> #ifndef PCI_SCAN_ALL_FNS
> #define PCI_SCAN_ALL_FNS 0
> #endif
>
> in the generic code, then just set it to 1 before asm-generic/pci.h
> gets included. That would mean updating arch code though.
>

If its just x86 then that's OK, but I'd prefer not to have to touch all
arches. Hm, doesn't look too bad.

> Anyway it's not a big deal, this code is already ugly (a 0 define for
> all arches? why?) so you shouldn't have to spend too much time
> cleaning it up.
>

Yes, it seems to be a vestigial thing which goes into pre-git-history.
I think when I dug into it, I found there was one Power user of it, but
that use evaporated in their arch unification. But I might be
mis-remembering.

J