From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Neil Turton <nturton@solarflare.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH] Fixed the handling of device aliases in the AMD IOMMU driver.
Date: Thu, 14 May 2009 15:47:30 +0200 [thread overview]
Message-ID: <20090514134730.GM9835@amd.com> (raw)
In-Reply-To: <4A0C17BB.4010300@solarflare.com>
On Thu, May 14, 2009 at 02:08:11PM +0100, Neil Turton wrote:
> The devid parameter to set_dev_entry_from_acpi is the requester ID
> rather than the device ID since it is used to index the IOMMU device
> table. The handling of IVHD_DEV_ALIAS used to pass the device ID.
> This patch fixes it to pass the requester ID.
>
> Signed-off-by: Neil Turton <nturton@solarflare.com>
> ---
> arch/x86/kernel/amd_iommu_init.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
> index 61479ba..c013906 100644
> --- a/arch/x86/kernel/amd_iommu_init.c
> +++ b/arch/x86/kernel/amd_iommu_init.c
> @@ -618,7 +618,7 @@ static void __init init_iommu_from_acpi(struct amd_iommu *iommu,
> case IVHD_DEV_ALIAS:
> devid = e->devid;
> devid_to = e->ext >> 8;
> - set_dev_entry_from_acpi(iommu, devid, e->flags, 0);
> + set_dev_entry_from_acpi(iommu, devid_to, e->flags, 0);
> amd_iommu_alias_table[devid] = devid_to;
> break;
> case IVHD_DEV_ALIAS_RANGE:
Applied too, thanks.
--
| Advanced Micro Devices GmbH
Operating | Karl-Hammerschmidt-Str. 34, 85609 Dornach bei München
System |
Research | Geschäftsführer: Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
| Registergericht München, HRB Nr. 43632
prev parent reply other threads:[~2009-05-14 13:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 13:08 [PATCH] Fixed the handling of device aliases in the AMD IOMMU driver Neil Turton
2009-05-14 13:47 ` Roedel, Joerg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090514134730.GM9835@amd.com \
--to=joerg.roedel@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nturton@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox